Skip to content

feat: Infra restructure mirror toolkit layout under infra/bicep, infra/avm#269

Draft
Prachig-Microsoft wants to merge 4 commits into
devfrom
psl/infra-restructure
Draft

feat: Infra restructure mirror toolkit layout under infra/bicep, infra/avm#269
Prachig-Microsoft wants to merge 4 commits into
devfrom
psl/infra-restructure

Conversation

@Prachig-Microsoft

Copy link
Copy Markdown
Contributor

This pull request introduces several infrastructure improvements and refactoring, primarily focused on Azure Bicep modules and deployment workflows. The main highlights are the addition of new Bicep modules for AI resources and role assignments, updates to deployment parameter files, and workflow changes to reflect new script locations. These changes help modularize the infrastructure codebase, improve maintainability, and align scripts and documentation with the new directory structure.

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

…, infra/scripts

User Story 45200. Adds infra/bicep/ (mirror of active main.bicep with domain-organized modules under modules/{ai,identity,networking}), infra/avm/ scaffold for future AVM rewrite, and moves provisioning scripts from /scripts to infra/scripts/{pre-provision,post-provision,build,utilities}. Updates GitHub Actions workflows and QuotaCheck.md to reference new script paths. Top-level main.bicep / main.json remain the canonical deployment artifacts referenced by azure.yaml.
…avm (mimics agentic-applications PR)

User Story 45200. Replaces custom modules in infra/bicep/modules/ with toolkit
vanilla-bicep modules from mcaps-microsoft/accelerator-toolkit-core@psl/infra
(ai/, data/, identity/, monitoring/, compute/) plus Container Apps modules
(container-app.bicep, container-app-environment.bicep). Rewrites
infra/bicep/main.bicep and main_custom.bicep to call toolkit modules in the same
style as microsoft/agentic-applications-for-unified-data-foundation-solution-
accelerator@psl/infra-restructure-new.

Populates infra/avm/ with toolkit AVM modules and matching main.bicep/main.json.

Top-level infra/main.bicep / main.json remain the canonical deployment artifacts
referenced by azure.yaml - unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…F, role-assignment GUID fix)

- Add virtual-machine.bicep AVM module with Entra ID authentication
- Update container-app-environment.bicep (both flavors): add workloadProfiles,
  WAF params (enablePrivateNetworking, enableMonitoring, enableRedundancy)
- Fix role-assignments.bicep GUID generation: scope to target resource ID
  instead of resourceGroup().id to prevent collisions
- Add VM module call to infra/avm/main.bicep with default credentials
- Regenerate main.json for both bicep and avm flavors

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant