Repository navigation
Commit f45db71
fix(release): derive the npm publish set instead of hardcoding it
`.github/workflows/publish-npm.yml` carried its own hardcoded list of 13
package directories while `scripts/release.mjs` DERIVED the same set (every
non-private package at the CLI's version). Two answers to one question, and
they had drifted: `@metaobjectsdev/docs-site` is a runtime `dependencies` entry
of `@metaobjectsdev/cli` and was not in the workflow's list, so a release cut
through the workflow would have published a `cli` pinning a `docs-site` version
nobody published — `npm i @metaobjectsdev/cli` → ETARGET. Only an external
install could have found it; the local release path publishes all 14, which is
what kept it latent (docs-site@0.23.2 is on npm today).
`scripts/publish-set.mjs` is now the single source of truth for which packages
ship and in what order. Both publish paths read it and the workflow's list is
gone, so it cannot drift from a derivation it no longer has. The derivation
throws rather than returning a wrong set: a member with no declared tier, a set
not closed over its own sibling runtime deps, or a tier order that would publish
a dependency after its dependent.
TIER_ORDER omitted `docs-site` too, and that was not harmless: `indexOf()`
returns -1, which does not sort last — it sorts FIRST, so the local path
published docs-site ahead of `metadata` and `render`, the two packages it
depends on. The tier is declared now, and an undeclared one is an error.
- scripts/publish-set.mjs — the shared derivation + its three invariants
- scripts/test-publish-set.mjs — each invariant driven against a synthetic
workspace, plus a regression pinning docs-site before cli in the real tree
- scripts/ci-local.sh — new `publish-set parity` gate in the gates lane
- docs/RELEASING.md, AGENTS.md, CHANGELOG.md — record the rule
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 7920a69 commit f45db71
9 files changed
Lines changed: 951 additions & 611 deletions
File tree
- .github/workflows
- docs
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
7 | 16 | | |
8 | 17 | | |
9 | 18 | | |
| |||
38 | 47 | | |
39 | 48 | | |
40 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
41 | 53 | | |
42 | 54 | | |
43 | 55 | | |
| |||
60 | 72 | | |
61 | 73 | | |
62 | 74 | | |
| 75 | + | |
63 | 76 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
72 | 85 | | |
73 | 86 | | |
74 | | - | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
67 | 94 | | |
68 | 95 | | |
69 | 96 | | |
| |||
0 commit comments