Skip to content

Commit babb69c

Browse files
committed
no-mistakes(review): apply reviewer inline fixes
1 parent 849f955 commit babb69c

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎server/java/metadata/src/main/java/com/metaobjects/loader/ValidationPhase.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4588,6 +4588,13 @@ private static WalkedViaPath validateViaPath(String viaAttr, MetaRoot root,
45884588
// ADR-0042 — package-local object-reference resolution.
45894589
// =========================================================================
45904590

4591+
/** Every root-level object, in declaration order. */
4592+
private static java.util.List<MetaObject> rootObjects(MetaRoot root) {
4593+
java.util.List<MetaObject> out = new java.util.ArrayList<>();
4594+
for (MetaData c : root.getChildren(MetaData.class, false)) if (c instanceof MetaObject) out.add((MetaObject) c);
4595+
return out;
4596+
}
4597+
45914598
/**
45924599
* ADR-0042 — resolve a metadata OBJECT reference to a top-level {@link MetaObject}
45934600
* under the package-local contract, or {@code null} when nothing matches:
@@ -4607,13 +4614,6 @@ private static WalkedViaPath validateViaPath(String viaAttr, MetaRoot root,
46074614
*
46084615
* @param referrerPkg the effective package of the node carrying the ref ("" for root-level)
46094616
*/
4610-
/** Every root-level object, in declaration order. */
4611-
private static java.util.List<MetaObject> rootObjects(MetaRoot root) {
4612-
java.util.List<MetaObject> out = new java.util.ArrayList<>();
4613-
for (MetaData c : root.getChildren(MetaData.class, false)) if (c instanceof MetaObject) out.add((MetaObject) c);
4614-
return out;
4615-
}
4616-
46174617
public static MetaObject resolveRootObject(MetaRoot root, String ref, String referrerPkg) {
46184618
if (ref == null) return null;
46194619
// ADR-0059 R2 — the one resolver: ::Rest, ..::Rest, pkg::Name, bare Name. An over-dropping

‎server/typescript/packages/metadata/src/core/relationship/find-reference.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function findReferenceBetween(
7272
/**
7373
* The name a `@via` hop takes when it walks the REVERSE of an
7474
* identity.reference, from the referenced entity back to the one that declares it:
75-
* the holder's collection name, lowerFirst(<Holder's collection name>) — its @collectionName, else the project's pluralizer — `consents` for
75+
* the holder's collection name (its @collectionName, else the project's pluralizer), lowerFirst — `consents` for
7676
* `Consent`, so `Patient.consents` walks Consent.patient backwards. One rule for every port.
7777
*/
7878
export function reverseHopName(holder: MetaObject): string {

0 commit comments

Comments
 (0)