You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9162f87
Browse filesBrowse the repository at this point in the historyBrowse files
fix(loader): exempt abstract nodes from the required-attr check (#236)
The generic required-attr check flagged an ABSTRACT node for a missing required attr, so an
abstract `template.prompt` that hoists shared children but leaves `@payloadRef` to its concrete
subtypes (or to `extends`) failed to load — forcing every concrete prompt to restate it. An
abstract is a template, not an instantiated node, so it is now exempt; enforcement stays at the
concrete level (a concrete node's RESOLVING attr set must still satisfy the requirement — a
concrete missing @payloadRef, inherited or own, still errors ERR_MISSING_REQUIRED_ATTR).
All four loader ports already read the resolving set for this check (so a concrete inheriting
via extends was already satisfied); the #236 diagnosis ("own-only") was slightly off — the real
gap was the abstract exemption. Fixed identically in TS/Java/Python/C# (Kotlin inherits the JVM
loader); consistent with ADR-0039. Gated by the abstract-template-prompt-hoists-payloadref
conformance fixture (254 metamodel fixtures; TS/Java/Python/C# green) + TS unit tests
(abstract-omits loads; concrete-inherits loads; concrete-missing still errors).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014xy8powhHYJ6gfFt9Ut8dL
Copy file name to clipboardExpand all lines: CLAUDE.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -30,7 +30,7 @@ _Last refreshed 2026-07-26._
30
30
-**Kotlin** — `codegen-kotlin` (KotlinPoet on JVM): entity + Exposed table + Spring controller + payload + relations + filter allowlist + validator + stored-proc + output-parser generators. `integration-tests-kotlin` runs the persistence-conformance corpus through Exposed against Testcontainers Postgres.
31
31
32
32
**Cross-port conformance corpora** (every port runs the shared corpus):
33
-
- Metamodel: `fixtures/conformance/` (253 fixtures; 19 shared corpora in total — per-corpus counts + the corpus x port matrix live in `docs/CONFORMANCE.md`). TS / C# / Java / Python all green.
33
+
- Metamodel: `fixtures/conformance/` (254 fixtures; 19 shared corpora in total — per-corpus counts + the corpus x port matrix live in `docs/CONFORMANCE.md`). TS / C# / Java / Python all green.
- Persistence: `fixtures/persistence-conformance/`. **Query** scenarios run on every port (TS / C# / Java / Kotlin / Python), each provisioning its test DB by executing the committed, TS-produced `canonical/schema.postgres.sql` (Postgres only — Derby dropped for the cross-port query corpus, ADR-0015). The **migration** scenarios are exercised by **TS only** (TS owns schema migrations). **The corpus now gates WRITES, not just reads (SP-H):** an `op: roundtrip` scenario type INSERTs through each port's runtime/ORM write codec (NOT raw SQL), reads the row back, and asserts the wire-normalized value. The `AllTypes` entity (`roundtrip-all-types.yaml`) carries one field of **every** persistable `field.*` subtype — string/int/long/double/float/decimal/boolean/date/time/timestamp(+tz)/currency/enum/uuid/object — plus an **array-of-VO** `field.object @isArray @storage:jsonb` column (`labels`, written as 2-element / empty-`[]` / single-element arrays across the three rows) — so every subtype write+read (incl. the array-of-value-object jsonb codec) round-trips through every port against Testcontainers PG. (`field.byte`/`field.short`/`field.class` were cut as non-functional registration-only stubs — the matrix tracks only genuinely-supported subtypes; see `fixtures/registry-conformance/README.md` → "Per-subtype write-round-trip matrix".)
36
36
- API-contract: `fixtures/api-contract-conformance/`. TS / C# / Java / Kotlin / Python all green — each port runs **two lanes**: a hand-rolled reference server AND its **generated** API artifact booted over HTTP (the deployed controller/routes; TS+C# full-stack vs Testcontainers PG, Java/Kotlin/Python generated controller + in-memory repo behind the consumer seam). The generated fan-out found 10 real deployment bugs golden snapshots missed.
0 commit comments