Skip to content

Commit 8c3a8ee

Browse files
committed
style: restore two doc-comment bindings the new code displaced
Simplifier pass over the branch. Both are comment/import placement, zero behavior change, no test touched: - verified-by-scan.ts: findOutsideCorpus's JSDoc had landed above the TESTISH_* constants, with an unrelated doc-comment sandwiched between it and the function it describes. - render/verify.py: the new payload_accessors import was inserted between ERR_VAR_NOT_ON_PAYLOAD's `#:` doc-comment and the constant, breaking the binding Sphinx reads. The rest of the branch was reviewed and deliberately left alone: the four ports already express the same presence rules, and the two-pass recurse-then-derive structure is duplicated on purpose rather than being cruft -- collapsing it in TS alone would make one port diverge for no gain in clarity. One genuine cross-port asymmetry was found and NOT changed: Python's first recursion pass copies non-string dict keys where C#/Java filter them in both passes. Changing it would alter output for a shape the conformance corpus does not cover, which is a corpus-fixture decision rather than a cleanup-pass one. cli 559 tests pass; python render 257 passed.
1 parent 4e757c8 commit 8c3a8ee

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎server/python/src/metaobjects/render/verify.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
from dataclasses import dataclass
2424
from typing import Protocol
2525

26-
#: A ``{{var}}`` references a field the (contextual) payload does not declare.
2726
from .payload_accessors import is_boolean_accessor
2827

28+
#: A ``{{var}}`` references a field the (contextual) payload does not declare.
2929
ERR_VAR_NOT_ON_PAYLOAD = "ERR_VAR_NOT_ON_PAYLOAD"
3030
#: A ``{{> ref}}`` partial does not resolve in the provider.
3131
ERR_PARTIAL_UNRESOLVED = "ERR_PARTIAL_UNRESOLVED"

‎server/typescript/packages/cli/src/lib/verified-by-scan.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,6 @@ function walk(
176176
}
177177
}
178178

179-
/**
180-
* Where does this name live, if not in the test corpus?
181-
*
182-
* Only ever called on the miss path, so the cost is paid per BROKEN claim rather than
183-
* per run. Returns the first unclassified source file containing the name, which is
184-
* enough to tell the author which pattern they are missing.
185-
*/
186179
/** Does this path or body look like a test the corpus definition simply did not match?
187180
* Deliberately narrow: living under a test directory, or containing an assertion/test
188181
* declaration. Without this, a name occurring anywhere in PRODUCTION source downgrades a
@@ -197,6 +190,13 @@ function looksLikeTest(rel: string, lines: string[]): boolean {
197190
return TESTISH_PATH.test(rel) || lines.some((l) => TESTISH_BODY.test(l));
198191
}
199192

193+
/**
194+
* Where does this name live, if not in the test corpus?
195+
*
196+
* Only ever called on the miss path, so the cost is paid per BROKEN claim rather than
197+
* per run. Returns the first unclassified source file containing the name, which is
198+
* enough to tell the author which pattern they are missing.
199+
*/
200200
function findOutsideCorpus(name: string, root: string, files: string[]): string | undefined {
201201
const rx = wordRx(name);
202202
for (const rel of files) {

0 commit comments

Comments
 (0)