fix(cli): the missing-FK-index advisory suggests a table-unique index name

The advisory suggested `by<Field>`, so every entity sharing an FK field
got the same suggestion. Postgres index names are schema-wide: an adopter
applying it verbatim for Citation.auditEntryId and Approval.auditEntryId
had `meta migrate` fail with ERR_DUPLICATE_SQL_NAME. The suggestion is
now `<entity>By<Field>`; a new test covers two entities with one field.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M1mRRB1K2WdYy82kntMQdx

Author: dmealing

CHANGELOG.md

@@ -21,6 +21,11 @@ here.**
 
 ### Fixed
 
+- **The missing-FK-index advisory suggests a name unique to the table.** It suggested
+  `by<Field>`, so two entities with the same FK field (`Citation.auditEntryId`,
+  `Approval.auditEntryId`) were both told `byAuditEntryId`. Postgres index names are schema-wide,
+  and applying the advice verbatim failed `meta migrate` with `ERR_DUPLICATE_SQL_NAME`. The
+  suggestion is now `<entity>By<Field>` (`citationByAuditEntryId`).
 - **Python `verify --codegen` no longer passes while checking nothing.** With no
   `--generators` it printed a note and exited 0. Since 1.0.4 there is no default suite, so a CI
   step written before then regenerated nothing and passed over committed output (one adopter's

server/typescript/packages/cli/src/lib/fk-index-advisory.ts

@@ -96,7 +96,10 @@ export function scanForUnindexedForeignKeys(root: MetaData, opts: UnindexedFkOpt
       });
       const fields = ref !== undefined ? ref.fields : fk.columns;
       const label = ref !== undefined ? `${entity.name}.${ref.name}` : `${entity.name} (${fk.name})`;
-      const indexName = `by${fields.map(pascal).join("")}`;
+      // Entity-prefixed: an index name is schema-wide in Postgres, so a bare `by<Field>`
+      // suggested the SAME name to every entity sharing the FK field, and applying the advice
+      // verbatim failed `meta migrate` with ERR_DUPLICATE_SQL_NAME.
+      const indexName = `${entity.name.charAt(0).toLowerCase()}${entity.name.slice(1)}By${fields.map(pascal).join("")}`;
       const fieldList = fields.length === 1 ? fields[0]! : `[${fields.join(", ")}]`;
       out.push({
         file: files[0] ?? "",

server/typescript/packages/cli/test/verify-fk-index-lint.test.ts

@@ -136,3 +136,38 @@ describe("meta verify — unindexed foreign keys (advisory)", () => {
     expect(help).not.toContain("hand-roll");
   });
 });
+
+// The suggested name was `by<Field>`. Postgres index names are schema-wide, so two entities
+// with the same FK field were both told `byAuditEntryId`, and taking the advice verbatim made
+// `meta migrate` fail with ERR_DUPLICATE_SQL_NAME (found applying the advisory on an adopter).
+// The suggestion names the entity too.
+describe("meta verify — the suggested FK index name is unique per table", () => {
+  test("two entities with the same FK field get different suggested names", async () => {
+    const root = await mkdtemp(join(tmpdir(), "verify-fk-index-names-"));
+    dirs.push(root);
+    await mkdir(join(root, "metaobjects"), { recursive: true });
+    const entity = (name: string, table: string) => ({ "object.entity": { name, children: [
+      { "source.rdb": { "@table": table } },
+      { "field.long": { name: "id" } },
+      { "field.long": { name: "auditEntryId", "@required": true } },
+      { "identity.primary": { name: "pk", "@fields": ["id"], "@generation": "increment" } },
+      { "identity.reference": { name: "fkAudit", "@fields": ["auditEntryId"], "@references": "AuditEntry" } },
+    ] } });
+    await writeFile(join(root, "metaobjects", "meta.audit.json"), JSON.stringify({ "metadata.root": {
+      package: "audit",
+      children: [
+        { "object.entity": { name: "AuditEntry", children: [
+          { "source.rdb": { "@table": "audit_entries" } },
+          { "field.long": { name: "id" } },
+          { "identity.primary": { name: "pk", "@fields": ["id"], "@generation": "increment" } },
+        ] } },
+        entity("Citation", "citations"),
+        entity("Approval", "approvals"),
+      ],
+    } }), "utf8");
+    const { out } = await capture(() => verifyCommand([], root));
+    expect(out).toContain("name: citationByAuditEntryId");
+    expect(out).toContain("name: approvalByAuditEntryId");
+    expect(out).not.toContain("name: byAuditEntryId");
+  });
+});