Repository navigation
Commit 7935582
fix(codegen): a retired stub told the reader to revive the capability
Two review findings on the requirement-test renderer and its tests.
THE SKIPPED BODY SAID THE OPPOSITE OF WHAT RETIRED MEANS. After `retired` joined
the skip set it shared a body with `planned`: "Intended, not built. Write the
assertion when this becomes live." For a retired entry that instructs the reader
to revive a capability that was deliberately removed — inverting the one
guardrail 0.24.2 restored `retired` for. The two skipped statuses mean opposite
things and now get opposite bodies; the repo's own harness generator already
branched here, so the correct wording existed one file over.
THE STATUS TEST ONLY PROVED THE CODE AGREED WITH ITSELF. Deriving SKIPS and FAILS
from the same two constants the implementation derives SKIPPED_STATUSES from
removed the independent signal: move `retired` into the live-nodes list by
mistake and both sides follow, every assertion follows, and every retired entry
emits a permanently red stub with the suite still green — the regression the
block exists for. The expectations are literal again, with an exhaustiveness
check underneath asserting the two lists are exactly the loader's enum and agree
with what it means. That keeps the independence without reintroducing the
staleness that started this: the lists previously named `abandoned` and
`superseded` for a release after the loader stopped accepting them.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NynrRND6ZUwGvq3ZUTCfxG1 parent 70e35c6 commit 7935582
3 files changed
Lines changed: 37 additions & 3 deletions
File tree
- server/typescript/packages/codegen-ts
- src/templates
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
120 | 127 | | |
121 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
122 | 132 | | |
123 | 133 | | |
124 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
159 | | - | |
160 | | - | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
161 | 180 | | |
162 | 181 | | |
163 | 182 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
54 | 59 | | |
55 | 60 | | |
56 | 61 | | |
| |||
0 commit comments