@@ -48,10 +48,103 @@ def test_served_report_predicate_follows_table_a() -> None:
4848 assert is_served_report (report_read_model (_obj (root , "InvoiceStatusTotals" ), root ))
4949
5050
51- def test_only_an_object_with_a_single_field_identity_has_an_item_route () -> None :
51+ def _projection (* , identity : list [str ] | None , id_field : bool ) -> MetaObject :
52+ from metaobjects .meta .core .field .meta_field import MetaField
53+ from metaobjects .meta .core .identity .identity_constants import (
54+ IDENTITY_ATTR_FIELDS ,
55+ IDENTITY_SUBTYPE_PRIMARY ,
56+ )
57+ from metaobjects .meta .core .identity .meta_identity import MetaIdentity
58+ from metaobjects .meta .persistence .source .meta_source import MetaSource
59+ from metaobjects .meta .persistence .source .source_constants import (
60+ SOURCE_ATTR_KIND ,
61+ SOURCE_KIND_VIEW ,
62+ SOURCE_SUBTYPE_RDB ,
63+ )
64+ from metaobjects .shared .base_types import TYPE_FIELD , TYPE_IDENTITY , TYPE_SOURCE
65+
66+ obj = MetaObject (TYPE_OBJECT , "projection" , "Summary" )
67+ obj .package = "acme::test"
68+ src = MetaSource (TYPE_SOURCE , SOURCE_SUBTYPE_RDB , "" )
69+ src .set_attr (SOURCE_ATTR_KIND , SOURCE_KIND_VIEW , sub_type = "string" )
70+ obj .add_child (src )
71+ names = (["id" ] if id_field else []) + ["code" , "other" ]
72+ for n in names :
73+ obj .add_child (MetaField (TYPE_FIELD , "int" , n ))
74+ if identity is not None :
75+ ident = MetaIdentity (TYPE_IDENTITY , IDENTITY_SUBTYPE_PRIMARY , "pk" )
76+ ident .set_attr (IDENTITY_ATTR_FIELDS , identity )
77+ obj .add_child (ident )
78+ return obj
79+
80+
81+ def _has_item_surface (src : str ) -> bool :
82+ return (
83+ '@router.get("/{summary_id}")' in src
84+ and "def find_by_id(" in src
85+ and src .count ('"error": "method_not_allowed",' ) == 4
86+ )
87+
88+
89+ def test_a_report_never_has_an_item_route_even_with_a_derived_field_named_id () -> None :
5290 root = _load ()
91+ model = report_read_model (_obj (root , "InvoiceStatusTotals" ), root )
92+ assert not has_item_route (model )
93+ assert not has_item_route (_obj (root , "InvoiceStatusTotals" )) # the declared node too
5394 assert has_item_route (_obj (root , "Invoice" ))
54- assert not has_item_route (report_read_model (_obj (root , "InvoiceStatusTotals" ), root ))
95+ # A derived field named `id`: build a report whose dimension is `Invoice.id`.
96+ import json
97+
98+ from metaobjects .loader .meta_data_loader import MetaDataLoader
99+ from metaobjects .loader .sources import InMemoryStringSource
100+
101+ meta = json .loads ((_CORPUS / "meta.json" ).read_text ())
102+ meta ["metadata.root" ]["children" ].append ({"object.report" : {
103+ "name" : "ById" , "@from" : "Invoice" , "@dimensions" : ["id" ], "@measures" : ["invoices" ],
104+ "children" : [{"source.rdb" : {"@kind" : "view" , "@view" : "v_by_id" }}],
105+ }})
106+ # A dimension named after the key column: `Invoice.id` needs a dimension node.
107+ inv = next (c ["object.entity" ] for c in meta ["metadata.root" ]["children" ] if "object.entity" in c )
108+ inv ["children" ].append ({"dimension.attribute" : {"name" : "id" , "@of" : "Invoice.id" }})
109+ result = MetaDataLoader ().load ([InMemoryStringSource (json .dumps (meta ), "meta.json" )])
110+ assert not result .errors , [e .message for e in result .errors ]
111+ by_id = _obj (result .root , "ById" )
112+ read_model = report_read_model (by_id , result .root )
113+ assert "id" in [f .name for f in read_model .fields ()]
114+ assert not has_item_route (read_model )
115+ src = render_router (read_model )
116+ assert src is not None and "find_by_id" not in src and "{" not in "" .join (
117+ ln for ln in src .splitlines () if ln .startswith ("@router." )
118+ )
119+
120+
121+ def test_a_projection_with_a_single_field_identity_has_the_item_surface () -> None :
122+ p = _projection (identity = ["id" ], id_field = True )
123+ assert has_item_route (p )
124+ assert _has_item_surface (render_router (p ))
125+
126+
127+ def test_a_projection_with_an_id_field_and_no_identity_has_the_item_surface () -> None :
128+ p = _projection (identity = None , id_field = True )
129+ assert has_item_route (p )
130+ assert _has_item_surface (render_router (p ))
131+
132+
133+ def test_a_composite_identity_keeps_its_item_route_bound_to_the_first_field () -> None :
134+ p = _projection (identity = ["code" , "other" ], id_field = False )
135+ assert has_item_route (p )
136+ assert _has_item_surface (render_router (p ))
137+
138+
139+ def test_a_projection_with_no_identity_and_no_id_field_is_keyless () -> None :
140+ p = _projection (identity = None , id_field = False )
141+ assert not has_item_route (p )
142+ src = render_router (p )
143+ assert src is not None
144+ decorators = re .findall (r'@router\.(\w+)\(("[^"]*")' , src )
145+ assert decorators == [("get" , '""' ), ("post" , '""' )], decorators
146+ assert "find_by_id" not in src
147+ assert src .count ('"error": "method_not_allowed",' ) == 1
55148
56149
57150def test_report_router_has_the_collection_routes_and_no_item_route () -> None :
@@ -97,18 +190,3 @@ def test_run_gen_serves_three_reports_and_nothing_for_the_sourceless_one(tmp_pat
97190 assert f"{ snake } _names.py" in files
98191 assert not any (f .startswith ("invoice_days" ) for f in files )
99192 assert not any ("invoice_days" in f for f in files )
100-
101-
102- def test_a_composite_identity_has_no_single_path_parameter () -> None :
103- from metaobjects .meta .core .identity .identity_constants import (
104- IDENTITY_ATTR_FIELDS ,
105- IDENTITY_SUBTYPE_PRIMARY ,
106- )
107- from metaobjects .meta .core .identity .meta_identity import MetaIdentity
108- from metaobjects .shared .base_types import TYPE_IDENTITY
109-
110- obj = MetaObject (TYPE_OBJECT , "projection" , "Pair" )
111- identity = MetaIdentity (TYPE_IDENTITY , IDENTITY_SUBTYPE_PRIMARY , "pk" )
112- identity .set_attr (IDENTITY_ATTR_FIELDS , ["a" , "b" ])
113- obj .add_child (identity )
114- assert not has_item_route (obj )
0 commit comments