Skip to content

Commit 578703c

Browse files
committed
no-mistakes(review): Scope prompts skill gate; add adoption eval case
1 parent 2ebe262 commit 578703c

9 files changed

Lines changed: 21 additions & 7 deletions

File tree

  • agent-context
  • fixtures/agent-context-conformance
    • java-kotlin-react-tanstack/expected/.claude/skills/metaobjects-prompts
    • java-react/expected/.claude/skills/metaobjects-prompts
    • python/expected/.claude/skills/metaobjects-prompts
    • ts-react-tanstack/expected/.claude/skills/metaobjects-prompts
    • ts-requirements/expected/.claude/skills/metaobjects-prompts

‎agent-context/evals/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ prompts, model edits that need no generated output) forbid it.
1818
agent-context/evals/run-skill-triggers.sh <out-dir>
1919
```
2020

21-
It starts real Claude sessions on your own login (24 cases x 3 runs = 72 sessions, a few
21+
It starts real Claude sessions on your own login (25 cases x 3 runs = 75 sessions, a few
2222
minutes with `-j 4`) and writes `<out-dir>/result.json`. Use `--case '<glob>'` to run a
2323
subset. It is not part of CI because model behaviour is not deterministic; CI only checks
2424
that the cases parse and name existing skills
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
type: tool_used
3+
tool: Skill
4+
input_match: metaobjects-prompts
5+
min: 1
6+
---
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
max_turns: 3
3+
timeout_seconds: 180
4+
allowed_tools: [Skill]
5+
runs: 3
6+
---
7+
8+
This project uses MetaObjects (it has .metaobjects/config.json and a metaobjects/ directory of meta.*.json files) but has not declared any template.prompt yet. Our ticket summarizer builds its LLM prompt with an f-string in summarize.py. I want to start declaring prompts the MetaObjects way, so move that prompt onto it.

‎agent-context/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

‎fixtures/agent-context-conformance/java-kotlin-react-tanstack/expected/.claude/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

‎fixtures/agent-context-conformance/java-react/expected/.claude/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

‎fixtures/agent-context-conformance/python/expected/.claude/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

‎fixtures/agent-context-conformance/ts-react-tanstack/expected/.claude/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

‎fixtures/agent-context-conformance/ts-requirements/expected/.claude/skills/metaobjects-prompts/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: metaobjects-prompts
3-
description: Use when writing, editing or reviewing code in a project that declares template.prompt nodes and that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing); test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt. Do not use for LLM code in a project that declares no template.prompt.
3+
description: Use when writing, editing or reviewing code that builds text sent to an LLM (string formatting, f-strings, text blocks, template literals, string builders, concatenation) or reads an LLM reply (regex, string search, JSON or XML parsing), in a project that declares template.prompt nodes; test harnesses and scripts count. That code belongs in a template, a payload VO and a response model. Also for declaring template.prompt/template.output, typed payload projections, provider-resolved text, deterministic render, prompt-drift verify and parser-on-receipt, including a MetaObjects project that has no template.prompt yet and wants to move existing LLM code onto them. Do not use to edit existing LLM code in a project that declares no template.prompt when the task is not declaring prompts.
44
---
55

66
# MetaObjects prompt construction

0 commit comments

Comments
 (0)