Skip to content

Commit 53c2387

Browse files
committed
no-mistakes(review): apply reviewer inline fixes
1 parent 0e6bf2f commit 53c2387

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎scripts/ci-local.sh‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@
5555
# # cube → the cube-model live check: a real Cube
5656
# # (cubejs/cube, pinned) over a private
5757
# # Postgres, both in docker (FR-044). Its
58-
# # own lane: the full run adds it after the
59-
# # integration suite; --quick and
58+
# # own lane: the full run runs it as its own
59+
# # parallel lane; --quick and
6060
# # --no-integration drop it; no other
6161
# # section includes it
6262
# scripts/ci-local.sh --no-integration
@@ -456,8 +456,8 @@ gate_site_payload() { bun_install && bun test scripts/site && bun scripts/build-
456456
# refusing the release cut (#447/#448 value-object null omission). No single CI lane has
457457
# mvn, dotnet and uv together, so this runs in the flagless full run only, which is the
458458
# one place all three coexist; it is absent from `--quick` (bun-only by design) and from
459-
# every `--only` lane. It needs the workspace built (`gate_ts_build_typecheck` earlier in
460-
# the same run) for the reason given above `gate_site_payload`.
459+
# every `--only` lane. It needs the workspace built (the full run's prelude build, before
460+
# its lanes start) for the reason given above `gate_site_payload`.
461461
gate_showcase_all_ports() { bun_install && bun scripts/regen-showcase.ts --check --all-ports; }
462462

463463
# ── the published metamodel reference tracks the registry ─────────────────────
@@ -780,7 +780,7 @@ gate_integration_port() { scripts/integration-test.sh "$1"; }
780780
# each served report's Cube query compared with its SQL view, then every Postgres case of the
781781
# mapping corpus compiled in the same Cube. It owns its containers and a private network, binds
782782
# only an ephemeral 127.0.0.1 port, and never uses the Postgres sidecar below. Its own lane
783-
# because the image is about 1 GB: `--only cube`, and the full run after the integration suite.
783+
# because the image is about 1 GB: `--only cube`, and the full run's `cube` lane.
784784
gate_cube() { scripts/integration-test.sh cube; }
785785

786786
# Docker down is a SKIP with a banner, never a quiet pass; --strict-toolchains makes it a FAIL.

0 commit comments

Comments
 (0)