no-mistakes(review): Ask git about ignored docs pages from the project root

Author: dmealing

server/typescript/packages/cli/src/lib/codegen-drift.ts

@@ -300,8 +300,10 @@ export async function computeCodegenDrift(
       // honourGlobalExcludes: false — a personal ignore file must not change a gate.
       let ignored: ReadonlySet<string> = new Set<string>();
       if (docsDirs.has(committed) && all.size > 0) {
-        const lookup = gitIgnored(committed, [...all].map(toPosix), { honourGlobalExcludes: false });
-        if ("ignored" in lookup) ignored = lookup.ignored;
+        const prefix = toPosix(relative(root, committed));
+        const fromRoot = (rel: string): string => (prefix === "" ? toPosix(rel) : `${prefix}/${toPosix(rel)}`);
+        const lookup = gitIgnored(root, [...all].map(fromRoot), { honourGlobalExcludes: false });
+        if ("ignored" in lookup) ignored = new Set([...all].map(toPosix).filter((rel) => lookup.ignored.has(fromRoot(rel))));
         else docsIgnoreUnavailable = lookup.unavailable;
         const checked = [...freshFiles].filter((rel) => !ignored.has(toPosix(rel)));
         if (freshFiles.size > 0 && checked.length === 0) {

server/typescript/packages/cli/test/gen-docs-generators.test.ts

@@ -330,6 +330,17 @@ describe("meta verify --codegen checks the documentation the list declares", ()
       "docs/generated: the repository git-ignores every documentation page generated there, so they were not compared.",
     );
   });
+
+  test("on a fresh clone, where the ignored docs directory does not exist, it is still not compared", async () => {
+    const root = project({ config: base(`["entity", docsFile()]`), ownRepo: true });
+    writeFileSync(join(root, ".gitignore"), "docs/\n", "utf8");
+    expect(await run(["gen", "--cwd", root])).toBe(0);
+    rmSync(join(root, "docs"), { recursive: true, force: true });
+    expect(await run(["verify", "--codegen", "--cwd", root])).toBe(0);
+    expect([...out, ...err].join("\n")).toContain(
+      "docs/generated: the repository git-ignores every documentation page generated there, so they were not compared.",
+    );
+  });
 });
 
 describe("an owned docs generator is wired like any other", () => {