From 6556867eed83f1da71c4da7355d6408075c9a241 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Tue, 27 Oct 2026 23:59:25 -0400 Subject: [PATCH] fix(scripts): run the check-script contract suite without the caller's CHECK_DATA_ROOT The members read CHECK_DATA_ROOT in place of the tree they run in, so a caller that sets it (ready's verify gate, a foreign check-affected run) pointed the negative fixtures at the caller's tree and three of them passed clean instead of exiting 1. Co-Authored-By: Claude Opus 5.5 --- scripts/check-script-contract.test.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/check-script-contract.test.sh b/scripts/check-script-contract.test.sh index 96d415882ab..ee64c83ff49 100755 --- a/scripts/check-script-contract.test.sh +++ b/scripts/check-script-contract.test.sh @@ -39,6 +39,9 @@ # basename is also what routes a member's changes back here, since # scripts/affected-tests.sh selects any suite that NAMES the changed file. set -uo pipefail +# Members read CHECK_DATA_ROOT in place of the tree they are run in, so a +# caller's value would point every fixture run at that caller's tree. +unset CHECK_DATA_ROOT SELF_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit 2 REPO_ROOT="$(cd "$SELF_DIR/.." && pwd)" || exit 2