Repository navigation
Commit 72cea0e
committed
fix(compat.opencl): name the Windows import libraries MSVC would have auto-linked
The first Windows section carried upstream's two link libraries and nothing
else, because that is all upstream's CMakeLists names. MSVC never has to name
the rest: its SDK headers pull the default import libraries in through
`#pragma comment(lib, ...)`. mcpp links with lld and does not inherit that.
The build compiled cleanly and failed at link with nine undefined symbols --
eight registry and process-token calls and `StringFromGUID2` -- so advapi32
and ole32 are named here.
Measured on this repository's Windows job, which is the only Windows this
change has. The compile was never the criterion.1 parent 63f50d6 commit 72cea0e
1 file changed
Lines changed: 22 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
209 | 226 | | |
210 | 227 | | |
211 | 228 | | |
| |||
0 commit comments