Repository navigation
Commit 0ce3d9c
committed
fix(ci): the registry cache must not carry the resolved index
`actions/cache` held all of `~/.mcpp/registry`, and that includes
`data/xim-pkgindex` and `data/mcpplibs` — the RESOLVED indices, the
descriptors mcpp actually reads. The key's `restore-keys` prefix ends at
MCPP_VERSION, so a run restored whatever index the previous run left
behind, regardless of what had landed upstream in between.
THIS ALREADY COST A DAY
Two successive fixes to `xim:wix` (openxlings/xim-pkgindex#808, then #809)
were each merged, each re-run here, and each appeared to change nothing.
Both were read as "the fix does not work" and the second one was written
on that false premise. Neither had ever been loaded.
The tell was in the logs the whole time: `7zip`, which #809 declares as a
dependency, appeared ZERO times in a run that was supposedly testing #809.
A fix that is not in the log is not being tested.
What eventually refreshed the index was moving MCPP_VERSION for unrelated
reasons — a coincidence of cache-key composition, not a mechanism anyone
chose. Until then the rule was, in effect: **a change to a xim package
cannot be verified from this repo's CI.**
EXCLUDE, DO NOT KEY ON IT
Adding the index revision to the key would evict everything on every
upstream commit. Measured on a developer machine: the two index trees are
~8 MB, `data/xpkgs` is ~28 GB. Re-fetching 8 MB per job is the cheap half
and it is the half that has to be current; rebuilding 28 GB because a
descriptor changed in another repository is the expensive half and it does
not.
So the payloads and toolchains stay cached and the indices stop being.1 parent 18dfa0b commit 0ce3d9c
1 file changed
Lines changed: 26 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
972 | 972 | | |
973 | 973 | | |
974 | 974 | | |
975 | | - | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
976 | 1001 | | |
977 | 1002 | | |
978 | 1003 | | |
| |||
0 commit comments