Repository navigation
Commit ad8adbb
committed
The first thing the new refusal caught was this repository's own fixtures
Three e2e fixtures built a `build.mcpp` that read `mcpp::device_sources()`,
printed it, and compiled nothing. They were asserting on the env contract, which
is a real thing to assert on -- and they were modelling a project whose device
files compile to nothing, which is exactly the defect the new refusal exists to
catch. So the refusal caught them, and it was right to.
606, 609 and 613 now declare a `check` action per device source, which is the
edge a real rule package declares, and go on asserting on the variable exactly
as before. The action's input has to be ABSOLUTE: `device_sources()` is
package-root-relative and an action does not run in the package root, which the
first attempt got wrong and `cp: cannot stat 'shaders/s.tesc'` said plainly.
EXAMPLE 05 PINS ITS TOOLCHAIN, and this is a different failure that surfaced in
the same run. `mcpp pack` names its output directory after the ABI tag, and the
consumer beside it names that directory literally -- so the pair only agrees on
a machine whose DEFAULT toolchain is the one that produced the tag. Measured:
a runner whose sandbox had been left with an LLVM default produced
`mathkit-0.1.0-x86_64-linux-gnu-clang22-libcxx22-c++23` while the consumer
named the `gcc16-libstdcxx16` one, and the example that had passed for months
failed without anything in it changing.
An example that hard-codes an ABI tag has to name the toolchain that produces
it. That is not a workaround for CI: a packed artifact IS specific to the ABI
it was built against, which is the entire subject of that example, so leaving
the toolchain implicit was the inconsistency.1 parent 7a8cc01 commit ad8adbb
5 files changed
Lines changed: 115 additions & 0 deletions
File tree
- examples/05-lib-distribution
- consumer
- producer
- tests/e2e
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
10 | 29 | | |
11 | 30 | | |
12 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
7 | 26 | | |
8 | 27 | | |
9 | 28 | | |
| |||
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
52 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
53 | 62 | | |
54 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
55 | 82 | | |
56 | 83 | | |
57 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
42 | 50 | | |
43 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
44 | 69 | | |
45 | 70 | | |
46 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
37 | 45 | | |
38 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
39 | 64 | | |
40 | 65 | | |
41 | 66 | | |
| |||
0 commit comments