Skip to content

Commit 77dd965

Browse files
committed
ci(openkal-cross): the seventh call site, and a pin nobody was reminded to move
Two defects in one workflow, both found by reading a failure that was neither of them — `build 3 targets on macos` went red on PR #503 with: fatal: unable to access '…/openkal-llvm-runtime/': Could not resolve host: github.com ⭐ THE CLONE NOW USES `git_clone_retry.sh`, WHICH ALREADY EXISTED. That helper's own note counts "six call sites, one failure mode"; this workflow was not among them, and the mode duly arrived here. One name that did not resolve ended a 120-minute job in its first minute, beside a real failure it had nothing to do with. Every `git clone` in this repository now retries, except two inline copies in `ci-aarch64-fresh-install.yml` whose comment explains why they cannot use the script: that job checks the repository out LAST on purpose, so the helper is not on disk yet. ⚠️ AND `OPENKAL_BRANCH` WAS `feat/openkal-closure`, LONG AFTER THAT BRANCH MERGED. The comment beside it said "when they are on `main` this becomes `main`" — and the moment for that passed without anyone reading it again. Every run since verified this engine against a tree the ecosystem had left behind. That shape is not incidental today. Both regressions found while reviewing #503 hid behind exactly it: an ecosystem repository pinned to an older mcpp, an engine change that broke it, and two green CIs on either side of the break. A fixed reference kept a check passing by keeping it out of date.
1 parent a8d8bec commit 77dd965

1 file changed

Lines changed: 23 additions & 4 deletions

File tree

‎.github/workflows/openkal-cross.yml‎

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,16 @@ env:
6868
# (.github/tools/check_version_pins.sh) enforces the ones that exist and would
6969
# not know about a copy in this file.
7070
XLINGS_NON_INTERACTIVE: '1'
71-
# The branch of the openkal packages this change is verified against. They
72-
# move together with it; when they are on `main` this becomes `main`.
73-
OPENKAL_BRANCH: feat/openkal-closure
71+
# The branch of the openkal packages this change is verified against.
72+
#
73+
# ⚠️ IT WAS `feat/openkal-closure` UNTIL 2026-08-25, LONG AFTER THAT BRANCH
74+
# MERGED. A fixed name here is a pin nobody is reminded to move: the comment
75+
# said "when they are on `main` this becomes `main`" and the moment for that
76+
# passed without anyone reading it again. Every run since was verifying this
77+
# engine against a tree the ecosystem had left behind — and the two
78+
# regressions found today both hid behind exactly this shape, a pin that
79+
# keeps a check green by keeping it out of date.
80+
OPENKAL_BRANCH: main
7481

7582
jobs:
7683
build:
@@ -140,7 +147,19 @@ jobs:
140147
- name: The program — one source, three targets
141148
run: |
142149
set -euo pipefail
143-
git clone --quiet --depth 1 -b "$OPENKAL_BRANCH" \
150+
# ⚠️ THE SEVENTH CALL SITE. `git_clone_retry.sh` was written because a
151+
# runner's DNS hiccup is not a red build, and its own note counts
152+
# "six call sites, one failure mode" — this workflow was not among
153+
# them, and the mode duly arrived here. Measured on this job,
154+
# 2026-08-25:
155+
#
156+
# fatal: unable to access '…/openkal-llvm-runtime/':
157+
# Could not resolve host: github.com
158+
#
159+
# One name that did not resolve ended a 120-minute job in its first
160+
# minute, beside a real failure it had nothing to do with.
161+
"$GITHUB_WORKSPACE/.github/tools/git_clone_retry.sh" \
162+
--quiet --depth 1 -b "$OPENKAL_BRANCH" \
144163
https://github.com/mcpplibs/openkal-llvm-runtime "$RUNNER_TEMP/okl"
145164
cd "$RUNNER_TEMP/okl/examples/same-source"
146165
mkdir -p "$RUNNER_TEMP/out"

0 commit comments

Comments
 (0)