Commit 3ea3fb1
committed
PR #759, round 4: the Windows literal-to-optional<std::string> form, and a 5-line tighten so src/build/prepare/plan.cpp is back under the 2,500-line gate
The third CI round (run 36946677551) had two failures from the
#756/#757 commit's +12 lines:
- Windows clang+MSVC STL would not compile a literal returned directly to
std::optional<std::string> in engine_declined_because (execute.cppm:189).
std::string(...) makes the conversion explicit and identical on every
STL.
- src/build/prepare/plan.cpp went from 2,491 to 2,503 lines, three over
the check_file_lengths.sh cap. The new rootOf/recorded lambdas in
step13_source_packages carry DepSourceRoot (a comment is redundant
with the struct's own), and the two are tight enough to put the file
back at 2,498. No semantic change.
Local unit tests: 20/20 BuildCacheRecord tests pass (BuildCacheRecord,
DepSourcesNewerThan, ReadEngineBinding).1 parent cd8dad9 commit 3ea3fb1
2 files changed
Lines changed: 5 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
143 | | - | |
144 | | - | |
| 142 | + | |
145 | 143 | | |
146 | | - | |
147 | | - | |
| 144 | + | |
148 | 145 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
| 146 | + | |
| 147 | + | |
153 | 148 | | |
154 | 149 | | |
155 | 150 | | |
| |||
0 commit comments