Branch protection and merge rules?

[story645]

Hey folks, do we want to enable branch protection? and do we want a certain # of reviews to merge stuff? attn: @rougier

[jklymak]

I think our policy has been @rougier merges. It he can relinquish that if he likes, in which case I think one review is ok unless a re-architecture.

[rougier]

I'm not familiar with branch protection so I cannot really answer. Note that I'm late on GitHub notifications so do not wait for my review if too late (or you can mail me if really urgent)

[story645]

Branch protection means that GitHub will disallow pushing directly to main (well technically whichever branch you want) & won't let folks edit directly on main. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches

[rougier]

Thanks for the explanation. Not strong opinion on that, I'll follow your advice and expertise.