Skip to content

Fix system tests [no_release] #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AltamashShaikh merged 3 commits into from
Jun 3, 2026
Merged

Fix system tests [no_release] #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6d7624
Fix system tests [no_release]
lachiebol Jun 1, 2026
54052e3
Fix old test case
lachiebol Jun 2, 2026
a3335f1
Added old tests [no_release]
lachiebol Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/System/TwoVisitsWithCustomVariablesSegmentContainsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,26 +51,36 @@ public function getApiForTesting()
$api[] = 'Actions.getPageTitles';
}

$olderThanMatomo5110b1 = version_compare(Version::VERSION, '5.11.0-b1', '<');

$segmentsToTest = [
// array( SegmentString , TestSuffix , Array of API to test)
["pageTitle=@*_)%", '_SegmentPageTitleContainsStrangeCharacters', ['VisitsSummary.get']],
["pageUrl=@user/profile", '_SegmentPageUrlContains', $api],
["pageTitle=@Profile pa", '_SegmentPageTitleContains', $api],
["pageUrl!@user/profile", '_SegmentPageUrlExcludes', $api],
["pageTitle!@Profile pa", '_SegmentPageTitleExcludes', $api],
];

if (version_compare(Version::VERSION, '4.13.1-rc1', '>=')) {
$segmentsToTest[] = ["pageUrl=@user/profile", '_SegmentPageUrlContains', ['VisitsSummary.get', 'Actions.getPageTitles']];
$segmentsToTest[] = ["pageUrl=@user/profile", '_SegmentPageUrlContains' . ($olderThanMatomo5110b1 ? '_old' : ''), ['Actions.getPageUrls']];
$segmentsToTest[] = ["pageTitle=@Profile pa", '_SegmentPageTitleContains', ['VisitsSummary.get', 'Actions.getPageTitles']];
$segmentsToTest[] = ["pageTitle=@Profile pa", '_SegmentPageTitleContains' . ($olderThanMatomo5110b1 ? '_old' : ''), ['Actions.getPageUrls']];
} else {
$segmentsToTest[] = ["pageUrl=@user/profile", '_SegmentPageUrlContains', $api];
$segmentsToTest[] = ["pageTitle=@Profile pa", '_SegmentPageTitleContains', $api];
}

if (version_compare(Version::VERSION, '4.13.1-rc1', '>=')) {
// goals for pages reports had been changed in 4.13.1, so we don't perform this tests before

$segmentsToTest[] = ["pageTitle=@*_)%", '_SegmentPageTitleContainsStrangeCharacters', ['Actions.getPageTitles']];

// starts with
$segmentsToTest[] = ['pageUrl=^example.org/home', '_SegmentPageUrlStartsWith', ['Actions.getPageUrls']];
$segmentsToTest[] = ['pageUrl=^example.org/home', '_SegmentPageUrlStartsWith' . ($olderThanMatomo5110b1 ? '_old' : ''), ['Actions.getPageUrls']];
$segmentsToTest[] = ['pageTitle=^Profile pa', '_SegmentPageTitleStartsWith', ['Actions.getPageTitles']];

// ends with
$segmentsToTest[] = ['pageUrl=$er/profile', '_SegmentPageUrlEndsWith', ['Actions.getPageUrls']];
$segmentsToTest[] = ['pageUrl=$er/profile', '_SegmentPageUrlEndsWith' . ($olderThanMatomo5110b1 ? '_old' : ''), ['Actions.getPageUrls']];
$segmentsToTest[] = ['pageTitle=$page', '_SegmentPageTitleEndsWith', ['Actions.getPageTitles']];
}

Expand Down
2 changes: 1 addition & 1 deletion ...d/test_twoVisitsWithCustomVariables_SegmentPageTitleContains__Actions.getPageUrls_day.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>0</nb_conversions_page_rate>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
Expand Down
113 changes: 113 additions & 0 deletions ...st_twoVisitsWithCustomVariables_SegmentPageTitleContains_old__Actions.getPageUrls_day.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
<?xml version="1.0" encoding="utf-8" ?>
<result>
<row>
<label>/homepage</label>
<nb_visits>1</nb_visits>
<nb_uniq_visitors>1</nb_uniq_visitors>
<nb_hits>1</nb_hits>
<sum_time_spent>360</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<entry_nb_uniq_visitors>1</entry_nb_uniq_visitors>
<entry_nb_visits>1</entry_nb_visits>
<entry_nb_actions>3</entry_nb_actions>
<entry_sum_visit_length>364</entry_sum_visit_length>
<entry_bounce_count>0</entry_bounce_count>
<goals>
<row idgoal='1'>
<nb_conversions>1</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.3333</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>1</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
<revenue_entry>0</revenue_entry>
<nb_conversions_entry_rate>1</nb_conversions_entry_rate>
<revenue_per_entry>0</revenue_per_entry>
<nb_conversions_entry>1</nb_conversions_entry>
</row>
<row idgoal='2'>
<nb_conversions>1</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>1</nb_conv_pages_before>
<nb_conversions_attrib>1</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>1</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
<revenue_entry>0</revenue_entry>
<nb_conversions_entry_rate>1</nb_conversions_entry_rate>
<revenue_per_entry>0</revenue_per_entry>
<nb_conversions_entry>1</nb_conversions_entry>
</row>
</goals>
<avg_bandwidth>0</avg_bandwidth>
<avg_page_load_time>0</avg_page_load_time>
<avg_time_on_page>360</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>0%</exit_rate>
<url>http://example.org/homepage</url>
<segment>pageUrl==http%253A%252F%252Fexample.org%252Fhomepage</segment>
</row>
<row>
<label>user</label>
<nb_visits>1</nb_visits>
<nb_hits>2</nb_hits>
<sum_time_spent>0</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<exit_nb_visits>1</exit_nb_visits>
<goals>
<row idgoal='1'>
<nb_conversions>2</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
</goals>
<avg_bandwidth>0</avg_bandwidth>
<avg_page_load_time>0</avg_page_load_time>
<avg_time_on_page>0</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>100%</exit_rate>
<segment>pageUrl=^http%253A%252F%252Fpiwik.net%252Fuser</segment>
<subtable>
<row>
<label>/profile</label>
<nb_visits>1</nb_visits>
<nb_uniq_visitors>1</nb_uniq_visitors>
<nb_hits>2</nb_hits>
<sum_time_spent>0</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<exit_nb_uniq_visitors>1</exit_nb_uniq_visitors>
<exit_nb_visits>1</exit_nb_visits>
<goals>
<row idgoal='1'>
<nb_conversions>2</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>0</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
</goals>
<avg_time_on_page>0</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>100%</exit_rate>
<url>http://example.org/user/profile</url>
<segment>pageUrl==http%253A%252F%252Fexample.org%252Fuser%252Fprofile</segment>
</row>
</subtable>
</row>
</result>
2 changes: 1 addition & 1 deletion ...ted/test_twoVisitsWithCustomVariables_SegmentPageUrlContains__Actions.getPageUrls_day.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>0</nb_conversions_page_rate>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
Expand Down
113 changes: 113 additions & 0 deletions ...test_twoVisitsWithCustomVariables_SegmentPageUrlContains_old__Actions.getPageUrls_day.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
<?xml version="1.0" encoding="utf-8" ?>
<result>
<row>
<label>/homepage</label>
<nb_visits>1</nb_visits>
<nb_uniq_visitors>1</nb_uniq_visitors>
<nb_hits>1</nb_hits>
<sum_time_spent>360</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<entry_nb_uniq_visitors>1</entry_nb_uniq_visitors>
<entry_nb_visits>1</entry_nb_visits>
<entry_nb_actions>3</entry_nb_actions>
<entry_sum_visit_length>364</entry_sum_visit_length>
<entry_bounce_count>0</entry_bounce_count>
<goals>
<row idgoal='1'>
<nb_conversions>1</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.3333</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>1</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
<revenue_entry>0</revenue_entry>
<nb_conversions_entry_rate>1</nb_conversions_entry_rate>
<revenue_per_entry>0</revenue_per_entry>
<nb_conversions_entry>1</nb_conversions_entry>
</row>
<row idgoal='2'>
<nb_conversions>1</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>1</nb_conv_pages_before>
<nb_conversions_attrib>1</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>1</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
<revenue_entry>0</revenue_entry>
<nb_conversions_entry_rate>1</nb_conversions_entry_rate>
<revenue_per_entry>0</revenue_per_entry>
<nb_conversions_entry>1</nb_conversions_entry>
</row>
</goals>
<avg_bandwidth>0</avg_bandwidth>
<avg_page_load_time>0</avg_page_load_time>
<avg_time_on_page>360</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>0%</exit_rate>
<url>http://example.org/homepage</url>
<segment>pageUrl==http%253A%252F%252Fexample.org%252Fhomepage</segment>
</row>
<row>
<label>user</label>
<nb_visits>1</nb_visits>
<nb_hits>2</nb_hits>
<sum_time_spent>0</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<exit_nb_visits>1</exit_nb_visits>
<goals>
<row idgoal='1'>
<nb_conversions>2</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
</goals>
<avg_bandwidth>0</avg_bandwidth>
<avg_page_load_time>0</avg_page_load_time>
<avg_time_on_page>0</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>100%</exit_rate>
<segment>pageUrl=^http%253A%252F%252Fpiwik.net%252Fuser</segment>
<subtable>
<row>
<label>/profile</label>
<nb_visits>1</nb_visits>
<nb_uniq_visitors>1</nb_uniq_visitors>
<nb_hits>2</nb_hits>
<sum_time_spent>0</sum_time_spent>
<sum_bandwidth>0</sum_bandwidth>
<nb_hits_with_bandwidth>0</nb_hits_with_bandwidth>
<min_bandwidth />
<max_bandwidth />
<exit_nb_uniq_visitors>1</exit_nb_uniq_visitors>
<exit_nb_visits>1</exit_nb_visits>
<goals>
<row idgoal='1'>
<nb_conversions>2</nb_conversions>
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>0</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
</goals>
<avg_time_on_page>0</avg_time_on_page>
<bounce_rate>0%</bounce_rate>
<exit_rate>100%</exit_rate>
<url>http://example.org/user/profile</url>
<segment>pageUrl==http%253A%252F%252Fexample.org%252Fuser%252Fprofile</segment>
</row>
</subtable>
</row>
</result>
2 changes: 1 addition & 1 deletion ...ted/test_twoVisitsWithCustomVariables_SegmentPageUrlEndsWith__Actions.getPageUrls_day.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
<revenue>0</revenue>
<nb_conv_pages_before>3</nb_conv_pages_before>
<nb_conversions_attrib>0.6666</nb_conversions_attrib>
<nb_conversions_page_rate>0</nb_conversions_page_rate>
<nb_conversions_page_rate>1</nb_conversions_page_rate>
<nb_conversions_page_uniq>2</nb_conversions_page_uniq>
<revenue_attrib>0</revenue_attrib>
</row>
Expand Down
Loading
Loading