Package quality review: remaining roadmap (B-, 70.7/100)

[manaporkun]

Tracking issue for the remaining findings from the package quality review (overall B-, 70.7/100). The two highest-confidence P0s are already in flight; this tracks everything not yet addressed.

Already in flight

• ✅ fix: world-space group rotation + multi-renderer bounds #24 — world-space group rotation math (ToAngleAxis) + multi-renderer GetBounds (Encapsulate + zero-renderer guard)
• ✅ ci: fix release version over-bumping (tag-independent range) #25 — release auto-versioner over-bumping (tag-independent range)

Remaining

P0 — packaging / compatibility (needs a real Unity check)

• Make URP an optional/soft dependency. package.json hard-depends on com.unity.render-pipelines.universal@12.1.0 with zero URP C# usage, forcing every Built-in/HDRP consumer to install URP just for a gizmo. Move to an RP-agnostic shader include or a gated SubShader; drop the manifest dependency. Verify clean install in a Built-in-only project.
• Input System asmdef reference. Runtime asmdef references GUID:75469ad4d38634e559750d17036d5f7c (Unity.InputSystem) unconditionally while the TH_INPUTSYSTEM define is gated via versionDefines. Confirm whether a legacy-input-only project (no Input System package) still compiles; if not, gate or remove the hard reference. Needs a legacy-only project to confirm Unity's unresolved-GUID behavior.

P1 — correctness / coverage

• Multi-target average rotation. TransformGroup.GetAveragePosRotScale accumulates sumQuaternion *= target.rotation (quaternion product, not an average) — wrong ghost-pivot orientation for N>1 in Self space. Decide on semantics (active-object rotation, identity, or true mean) and implement.
• Test coverage. ~334 test LOC vs ~3,700 runtime LOC, concentrated in pure utils. Add EditMode/PlayMode tests for: TransformHandleManager lifecycle, plane/axis wiring (recent bug-fix area), snapping Relative/Absolute branches, Ghost/TransformGroup delta application across Self and World space.

P2 — polish

• ScaleGlobal framerate coupling. ScaleGlobal.Interact multiplies the per-frame pixel delta by Time.deltaTime, tying uniform-scale speed to FPS. Drop Time.deltaTime and re-tune MouseSensitivity (~60×) to preserve feel; verify by hand.
• Tighten public surface (pre-locking the API). public mutable fields (mainCamera, HandleBase.delta, axis fields) → controlled properties; make TransformGroup internal/read-only where possible; explicit integer values on serialized enums; rename UpdateGroupScaleUpdate; resolve the unused Origin enum.
• CI hardening. SHA-pin third-party actions; add a Unity 2021.3 matrix entry so the declared floor is actually verified (CI only runs 6000.3); add a publish concurrency guard; add dependabot.
• Doc accuracy. README quick-start logs handle.target (the ghost pivot, not the user's object); correct PreserveScaleOnScreenExtension naming in the migration guide; add <exception> tags to throwing methods.
• Version note. main is at 3.0.0 from the erroneous bump; decide whether to continue from 3.0.1 (recommended) or reset.

---

Full per-dimension scorecard available on request. Generated from a code-grounded review (claims verified against source before listing).

[manaporkun]

Progress + revised priorities (after grounding each finding in code)

Landed / in flight

• ✅ fix: world-space group rotation + multi-renderer bounds #24 — world-space rotation math + GetBounds (released in 3.0.1)
• ✅ ci: fix release version over-bumping (tag-independent range) #25 — release versioner over-bump (released; 3.0.0→3.0.1 patch, not major)
• ✅ ci: fix changelog heredoc delimiter (release notes step) #27 — changelog heredoc fix (GitHub Release now auto-creates; verified on 3.0.2)
• ✅ test: cover GetBounds + world/self group rotation #28 — test coverage: GetBounds + world/self UpdateRotations (released 3.0.2)
• 🔄 ci: harden publish (bump filter, concurrency, dependabot) #29 — CI hardening: bump filter ignores Tests/+Samples~/, publish concurrency guard, dependabot
• 🔄 docs: fix quick-start logging handle.target (pivot, not object) #30 — docs: quick-start handle.target clarification

Revised after investigation (both P0s downgraded):

• URP dependency — justified, not gratuitous. Both shaders ship dual SubShaders (URP + Built-in fallback), but the URP SubShader #includes com.unity.render-pipelines.universal/ShaderLibrary/Core.hlsl, which fails to compile in a Built-in-only project if URP is absent. So the hard dep is what keeps shaders compiling everywhere. Making it optional means gating/rewriting the URP SubShader — a real tradeoff, not a quick win. (Scorecard's "zero URP C# usage" is correct but isn't the reason for the dep.)
• Input System asmdef ref — likely harmless. All UnityEngine.InputSystem usage is behind #if ENABLE_INPUT_SYSTEM && TH_INPUTSYSTEM. In a legacy-only project the unresolved GUID reference is a warning, not an error (no guarded types compile). Downgraded from P0; the 2021.3 CI matrix below would confirm empirically.
• Migration-guide PreserveScaleOnScreen naming — not actually wrong (the method is PreserveScaleOnScreen; …Extension is just the static class). No change.

Still genuinely open

• 2021.3 CI matrix — verifies the declared floor (CI only runs 6000.3) and would settle the Input System / URP-on-floor questions empirically. Highest remaining value; risk of surfacing real compat work.
• Multi-target average rotation (GetAveragePosRotScale quaternion product) — needs a semantics decision (active-object vs identity vs true mean); pivot-display only.
• ScaleGlobal framerate coupling — drop Time.deltaTime, re-tune MouseSensitivity (~60×); needs feel-testing.
• More tests — manager lifecycle, snapping Relative/Absolute branches, plane/axis wiring.
• API surface tightening — fields→properties, explicit enum values, TransformGroup internal, rename UpdateGroupScaleUpdate, unused Origin enum.
• SHA-pin actions (dependabot from ci: harden publish (bump filter, concurrency, dependabot) #29 keeps them current; pinning is the stricter step).