Skip to content

chore(cli): kill subnet — zero subnet/Subnet/SUBNET in cli #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanzo-dev merged 1 commit into from
May 30, 2026
Merged

chore(cli): kill subnet — zero subnet/Subnet/SUBNET in cli #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/explorecmd/explore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"github.com/spf13/cobra"
)

var app *application.Lux

Check failure on line 18 in cmd/explorecmd/explore.go

View workflow job for this annotation

GitHub Actions / Lint 

var app is unused (U1000)

// NewCmd creates the explore command for running the block explorer.
func NewCmd(injectedApp *application.Lux) *cobra.Command {
Expand Down Expand Up @@ -46,7 +46,7 @@
}

cmd.Flags().String("rpc", "", "RPC endpoint (auto-detected from running network if not set)")
cmd.Flags().String("chain", "cchain", "Chain to index (cchain, xchain, pchain, or subnet name)")
cmd.Flags().String("chain", "cchain", "Chain to index (cchain, xchain, pchain, or chain name)")
cmd.Flags().Int("port", 8090, "HTTP port for explorer API")
cmd.Flags().String("data", "", "Data directory (default: ~/.lux/explorer/)")
cmd.Flags().Bool("open", true, "Open browser after starting")
Expand Down
2 changes: 1 addition & 1 deletion cmd/networkcmd/start_local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const (
)

// StartLocal starts a 3-node localnet on K8s via the operator.
// No netrunner — the operator manages StatefulSets, subnet creation, chain deployment.
// No netrunner — the operator manages StatefulSets, chain creation and deployment.
//
// lux network start --local
// lux network start --local --k8s colima
Expand Down
2 changes: 1 addition & 1 deletion pkg/mpc/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type DeploymentConfig struct {
AWSProfile string `json:"awsProfile,omitempty"`
AWSSecurityGroup string `json:"awsSecurityGroup,omitempty"`
AWSVPC string `json:"awsVpc,omitempty"`
AWSSubnet string `json:"awsSubnet,omitempty"`
AWSNet string `json:"awsNet,omitempty"`

// GCP specific
GCPProject string `json:"gcpProject,omitempty"`
Expand Down
12 changes: 6 additions & 6 deletions pkg/plugins/luxdConfig_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const (
chainName1 = "TEST_chain"
chainName2 = "TEST_copied_chain"

chainID = "testSubNet"
chainID = "testChain"
networkID = uint32(67443)
)

Expand All @@ -47,7 +47,7 @@ func TestEditConfigFileWithOldPattern(t *testing.T) {
defer func() { _ = os.Remove(configPath) }()

// testing backward compatibility
configBytes := []byte("{\"whitelisted-chains\": \"subNetId000\"}")
configBytes := []byte("{\"whitelisted-chains\": \"chainId000\"}")
err = os.MkdirAll(filepath.Dir(configPath), constants.DefaultPerms755)
require.NoError(err)
err = os.WriteFile(configPath, configBytes, 0o600)
Expand All @@ -63,7 +63,7 @@ func TestEditConfigFileWithOldPattern(t *testing.T) {
err = json.Unmarshal(fileBytes, &luxConfig)
require.NoError(err)

require.Equal("subNetId000,testSubNet", luxConfig["track-chains"])
require.Equal("chainId000,testChain", luxConfig["track-chains"])

// ensure that the old setting has been deleted
require.Equal(nil, luxConfig["whitelisted-chains"])
Expand All @@ -89,7 +89,7 @@ func TestEditConfigFileWithNewPattern(t *testing.T) {
defer func() { _ = os.Remove(configPath) }()

// testing backward compatibility
configBytes := []byte("{\"track-chains\": \"subNetId000\"}")
configBytes := []byte("{\"track-chains\": \"chainId000\"}")
err = os.MkdirAll(filepath.Dir(configPath), constants.DefaultPerms755)
require.NoError(err)
err = os.WriteFile(configPath, configBytes, 0o600)
Expand All @@ -105,7 +105,7 @@ func TestEditConfigFileWithNewPattern(t *testing.T) {
err = json.Unmarshal(fileBytes, &luxConfig)
require.NoError(err)

require.Equal("subNetId000,testSubNet", luxConfig["track-chains"])
require.Equal("chainId000,testChain", luxConfig["track-chains"])

// ensure that the old setting wont be applied at all
require.Equal(nil, luxConfig["whitelisted-chains"])
Expand Down Expand Up @@ -146,7 +146,7 @@ func TestEditConfigFileWithNoSettings(t *testing.T) {
err = json.Unmarshal(fileBytes, &luxConfig)
require.NoError(err)

require.Equal("testSubNet", luxConfig["track-chains"])
require.Equal("testChain", luxConfig["track-chains"])

// ensure that the old setting wont be applied at all
require.Equal(nil, luxConfig["whitelisted-chains"])
Expand Down
Loading