From 535b1bf87c44b2a1aa19c2cdbc7768c9181265dd Mon Sep 17 00:00:00 2001 From: Jeremy Date: Mon, 6 Apr 2026 17:00:11 -0700 Subject: [PATCH 1/4] Testing LuckyFlow PR to see if it fixes the flaky spec issues --- .../spec/flows/authentication_spec.cr.ecr | 4 ++-- .../spec/flows/reset_password_spec.cr.ecr | 2 +- src/lucky_cli/shard_file_generator.cr | 5 +++-- src/web_app_skeleton/spec/setup/start_app_server.cr.ecr | 3 +++ 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/browser_authentication_app_skeleton/spec/flows/authentication_spec.cr.ecr b/src/browser_authentication_app_skeleton/spec/flows/authentication_spec.cr.ecr index cee71bcd..907c8e45 100644 --- a/src/browser_authentication_app_skeleton/spec/flows/authentication_spec.cr.ecr +++ b/src/browser_authentication_app_skeleton/spec/flows/authentication_spec.cr.ecr @@ -4,7 +4,7 @@ require "../spec_helper" # This is due to race conditions in LuckyFlow. # Ref: https://github.com/luckyframework/lucky_cli/issues/883 describe "Authentication flow", tags: "flow" do - pending "works" do + it "works" do flow = AuthenticationFlow.new("test@example.com") flow.sign_up "password" @@ -20,7 +20,7 @@ describe "Authentication flow", tags: "flow" do # Use the `visit` method's `as` option in your tests to sign in as that user. # # Feel free to delete this once you have other tests using the 'as' option. - pending "allows sign in through backdoor when testing" do + it "allows sign in through backdoor when testing" do user = UserFactory.create flow = BaseFlow.new diff --git a/src/browser_authentication_app_skeleton/spec/flows/reset_password_spec.cr.ecr b/src/browser_authentication_app_skeleton/spec/flows/reset_password_spec.cr.ecr index 809a0322..f190389c 100644 --- a/src/browser_authentication_app_skeleton/spec/flows/reset_password_spec.cr.ecr +++ b/src/browser_authentication_app_skeleton/spec/flows/reset_password_spec.cr.ecr @@ -4,7 +4,7 @@ require "../spec_helper" # This is due to race conditions in LuckyFlow. # Ref: https://github.com/luckyframework/lucky_cli/issues/883 describe "Reset password flow", tags: "flow" do - pending "works" do + it "works" do user = UserFactory.create flow = ResetPasswordFlow.new(user) diff --git a/src/lucky_cli/shard_file_generator.cr b/src/lucky_cli/shard_file_generator.cr index cab8dca1..b6a32483 100644 --- a/src/lucky_cli/shard_file_generator.cr +++ b/src/lucky_cli/shard_file_generator.cr @@ -105,8 +105,9 @@ class ShardFileGenerator private def project_browser_dev_deps { "lucky_flow" => { - "github" => "luckyframework/lucky_flow", - "version" => "~> 0.10.1", + "github" => "wout/lucky_flow", + "branch" => "fix-race-conditions", + # "version" => "~> 0.10.1", }, } end diff --git a/src/web_app_skeleton/spec/setup/start_app_server.cr.ecr b/src/web_app_skeleton/spec/setup/start_app_server.cr.ecr index e239f37d..96818901 100644 --- a/src/web_app_skeleton/spec/setup/start_app_server.cr.ecr +++ b/src/web_app_skeleton/spec/setup/start_app_server.cr.ecr @@ -4,6 +4,9 @@ spawn do app_server.listen end +<%- if browser? -%> +LuckyFlow.wait_for_server +<%- end -%> Spec.after_suite do <%- if browser? -%> LuckyFlow.shutdown From 1de66f1e39242452ba68e0d0a3159bbdd50893c1 Mon Sep 17 00:00:00 2001 From: Jeremy Date: Mon, 6 Apr 2026 17:01:37 -0700 Subject: [PATCH 2/4] oops, formatter --- src/lucky_cli/shard_file_generator.cr | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lucky_cli/shard_file_generator.cr b/src/lucky_cli/shard_file_generator.cr index b6a32483..b04108e1 100644 --- a/src/lucky_cli/shard_file_generator.cr +++ b/src/lucky_cli/shard_file_generator.cr @@ -105,8 +105,8 @@ class ShardFileGenerator private def project_browser_dev_deps { "lucky_flow" => { - "github" => "wout/lucky_flow", - "branch" => "fix-race-conditions", + "github" => "wout/lucky_flow", + "branch" => "fix-race-conditions", # "version" => "~> 0.10.1", }, } From 2a3300542c9cd9e31e6e6b0296a0f0fe731ab02a Mon Sep 17 00:00:00 2001 From: Jeremy Date: Sun, 19 Apr 2026 17:08:09 -0700 Subject: [PATCH 3/4] Use latest LuckyFlow --- src/lucky_cli/shard_file_generator.cr | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lucky_cli/shard_file_generator.cr b/src/lucky_cli/shard_file_generator.cr index b04108e1..3878f0ca 100644 --- a/src/lucky_cli/shard_file_generator.cr +++ b/src/lucky_cli/shard_file_generator.cr @@ -106,8 +106,7 @@ class ShardFileGenerator { "lucky_flow" => { "github" => "wout/lucky_flow", - "branch" => "fix-race-conditions", - # "version" => "~> 0.10.1", + "version" => "~> 0.10.2", }, } end From 23d54c82f6574ae95c2fb508c2d6df10236fb156 Mon Sep 17 00:00:00 2001 From: Jeremy Date: Sun, 19 Apr 2026 17:19:23 -0700 Subject: [PATCH 4/4] oops, forgot to point back to the repo --- src/lucky_cli/shard_file_generator.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lucky_cli/shard_file_generator.cr b/src/lucky_cli/shard_file_generator.cr index 3878f0ca..121a6398 100644 --- a/src/lucky_cli/shard_file_generator.cr +++ b/src/lucky_cli/shard_file_generator.cr @@ -105,7 +105,7 @@ class ShardFileGenerator private def project_browser_dev_deps { "lucky_flow" => { - "github" => "wout/lucky_flow", + "github" => "luckyframework/lucky_flow", "version" => "~> 0.10.2", }, }