From 24d0178df8d3e58759dc6fb3c4d0a847dc8800a1 Mon Sep 17 00:00:00 2001 From: Brooke Ellis Date: Fri, 7 Aug 2026 15:13:51 -0500 Subject: [PATCH] solidigm: remove logically dead code in parse_tracker_chunk_json entry_info is guaranteed non-NULL at this point because the !entry_info guard above would have continued to the next loop iteration if it were NULL. The ternary expression entry_info ? get_arg_description(entry_info, i) : NULL therefore has a dead branch. Replace it with a direct call to get_arg_description(). Fixes Coverity CID 557386 (DEADCODE). Signed-off-by: Brooke Ellis --- plugins/solidigm/solidigm-telemetry/tracker.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/solidigm/solidigm-telemetry/tracker.c b/plugins/solidigm/solidigm-telemetry/tracker.c index 92999ce86b..6ce31e4bf6 100644 --- a/plugins/solidigm/solidigm-telemetry/tracker.c +++ b/plugins/solidigm/solidigm-telemetry/tracker.c @@ -448,9 +448,8 @@ static void parse_tracker_chunk_json(const struct telemetry_log *tl, uint32_t ch for (uint32_t i = 0; i < arg_count && i < MAX_ARGS && i < (uint32_t)array_len; i++) { char arg_key[16] = {0}; - const char *arg_desc = entry_info ? - get_arg_description(entry_info, i) - : NULL; + const char *arg_desc = + get_arg_description(entry_info, i); struct json_object *arg_val = json_object_array_get_idx(args_array, i);