From c09a724320ffafda32eae0fefe006bbcbb702dca Mon Sep 17 00:00:00 2001 From: Sarah Ahmed Date: Thu, 6 Aug 2026 09:29:12 -0500 Subject: [PATCH] solidigm-telemetry: check return value of sldm_telemetry_structure_parse The return value of sldm_telemetry_structure_parse() was not being checked before proceeding to use the parsed_struct object for NLOG and side trace processing. If parsing fails, the incomplete structure data would lead to invalid results in downstream operations. Check the return value and skip to the next iteration if parsing fails. Signed-off-by: Sarah Ahmed --- plugins/solidigm/solidigm-telemetry/data-area.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/plugins/solidigm/solidigm-telemetry/data-area.c b/plugins/solidigm/solidigm-telemetry/data-area.c index 4f32507ab5..2d3c9f323c 100644 --- a/plugins/solidigm/solidigm-telemetry/data-area.c +++ b/plugins/solidigm/solidigm-telemetry/data-area.c @@ -520,9 +520,10 @@ static void telemetry_log_data_area_toc_parse(const struct telemetry_log *tl, } object_file_offset = ((uint64_t)da_offset) + obj_offset + header_offset; if (has_struct) { - sldm_telemetry_structure_parse(tl, structure_definition, - NUM_BITS_IN_BYTE * object_file_offset, - parsed_struct, toc_item); + if (sldm_telemetry_structure_parse(tl, structure_definition, + NUM_BITS_IN_BYTE * object_file_offset, + parsed_struct, toc_item)) + continue; } // NLOGs have different parser from other Telemetry objects if (nlog_name) {