Implement InstanceExists

Author: okokes-akamai

cloud/linode/instances.go

@@ -210,9 +210,30 @@ func (i *instances) InstanceShutdownByProviderID(ctx context.Context, providerID
 	return false, nil
 }
 
-// TODO(PR): move code from instancesv1 over here
 func (i *instances) InstanceExists(ctx context.Context, node *v1.Node) (bool, error) {
-	return false, nil // TODO(PR): fix
+	providerID := node.Spec.ProviderID
+
+	ctx = sentry.SetHubOnContext(ctx)
+	sentry.SetTag(ctx, "provider_id", providerID)
+
+	id, err := parseProviderID(providerID)
+	if err != nil {
+		sentry.CaptureError(ctx, err)
+		return false, err
+	}
+
+	sentry.SetTag(ctx, "linode_id", strconv.Itoa(id))
+
+	_, err = linodeByID(ctx, i.client, id)
+	if err != nil {
+		if apiError, ok := err.(*linodego.Error); ok && apiError.Code == http.StatusNotFound {
+			return false, nil
+		}
+		sentry.CaptureError(ctx, err)
+		return false, err
+	}
+
+	return true, nil
 }
 
 func (i *instances) InstanceShutdown(ctx context.Context, node *v1.Node) (bool, error) {

cloud/linode/instances_test.go

@@ -24,36 +24,42 @@ func TestInstanceExistsByProviderID(t *testing.T) {
 	instances := newInstances(client)
 
 	t.Run("should propagate generic api error", func(t *testing.T) {
-		providerID := providerIDPrefix + "123"
+		node := &v1.Node{Spec: v1.NodeSpec{
+			ProviderID: providerIDPrefix + "123",
+		}}
 		expectedErr := errors.New("some error")
 		client.EXPECT().GetInstance(gomock.Any(), 123).Times(1).Return(nil, expectedErr)
 
-		exists, err := instances.InstanceExistsByProviderID(ctx, providerID)
+		exists, err := instances.InstanceExists(ctx, node)
 		assert.ErrorIs(t, err, expectedErr)
 		assert.False(t, exists)
 	})
 
 	t.Run("should return false if linode does not exist", func(t *testing.T) {
-		providerID := providerIDPrefix + "123"
+		node := &v1.Node{Spec: v1.NodeSpec{
+			ProviderID: providerIDPrefix + "123",
+		}}
 		client.EXPECT().GetInstance(gomock.Any(), 123).Times(1).Return(nil, &linodego.Error{
 			Code: http.StatusNotFound,
 		})
 
-		exists, err := instances.InstanceExistsByProviderID(ctx, providerID)
+		exists, err := instances.InstanceExists(ctx, node)
 		assert.NoError(t, err)
 		assert.False(t, exists)
 	})
 
 	t.Run("should return true if linode exists", func(t *testing.T) {
-		providerID := providerIDPrefix + "123"
+		node := &v1.Node{Spec: v1.NodeSpec{
+			ProviderID: providerIDPrefix + "123",
+		}}
 		client.EXPECT().GetInstance(gomock.Any(), 123).Times(1).Return(&linodego.Instance{
 			ID:     123,
 			Label:  "mock",
 			Region: "us-east",
 			Type:   "g6-standard-2",
 		}, nil)
 
-		exists, err := instances.InstanceExistsByProviderID(ctx, providerID)
+		exists, err := instances.InstanceExists(ctx, node)
 		assert.NoError(t, err)
 		assert.True(t, exists)
 	})