Skip to content

Commit 8c37946

Browse files
Remove BeTrue patterns from e2e tests (#157)
These Gomega patterns are hard to debug, remove these in favour of `Equal` calls.
1 parent af0a0b4 commit 8c37946

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

e2e/test/ccm_e2e_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,59 +170,59 @@ var _ = Describe("e2e tests", func() {
170170

171171
if args.checkType != "" {
172172
By("Checking Health Check Type")
173-
Expect(string(nbConfig.Check) == args.checkType).Should(BeTrue())
173+
Expect(string(nbConfig.Check)).To(Equal(args.checkType))
174174
}
175175

176176
if args.path != "" {
177177
By("Checking Health Check Path")
178-
Expect(nbConfig.CheckPath == args.path).Should(BeTrue())
178+
Expect(nbConfig.CheckPath).To(Equal(args.path))
179179
}
180180

181181
if args.body != "" {
182182
By("Checking Health Check Body")
183-
Expect(nbConfig.CheckBody == args.body).Should(BeTrue())
183+
Expect(nbConfig.CheckBody).To(Equal(args.body))
184184
}
185185

186186
if args.interval != "" {
187187
By("Checking TCP Connection Health Check Body")
188188
intInterval, err := strconv.Atoi(args.interval)
189189
Expect(err).NotTo(HaveOccurred())
190190

191-
Expect(nbConfig.CheckInterval == intInterval).Should(BeTrue())
191+
Expect(nbConfig.CheckInterval).To(Equal(intInterval))
192192
}
193193

194194
if args.timeout != "" {
195195
By("Checking TCP Connection Health Check Timeout")
196196
intTimeout, err := strconv.Atoi(args.timeout)
197197
Expect(err).NotTo(HaveOccurred())
198198

199-
Expect(nbConfig.CheckTimeout == intTimeout).Should(BeTrue())
199+
Expect(nbConfig.CheckTimeout).To(Equal(intTimeout))
200200
}
201201

202202
if args.attempts != "" {
203203
By("Checking TCP Connection Health Check Attempts")
204204
intAttempts, err := strconv.Atoi(args.attempts)
205205
Expect(err).NotTo(HaveOccurred())
206206

207-
Expect(nbConfig.CheckAttempts == intAttempts).Should(BeTrue())
207+
Expect(nbConfig.CheckAttempts).To(Equal(intAttempts))
208208
}
209209

210210
if args.checkPassive != "" {
211211
By("Checking for Passive Health Check")
212212
boolCheckPassive, err := strconv.ParseBool(args.checkPassive)
213213
Expect(err).NotTo(HaveOccurred())
214214

215-
Expect(nbConfig.CheckPassive == boolCheckPassive).Should(BeTrue())
215+
Expect(nbConfig.CheckPassive).To(Equal(boolCheckPassive))
216216
}
217217

218218
if args.protocol != "" {
219219
By("Checking for Protocol")
220-
Expect(string(nbConfig.Protocol) == args.protocol).Should(BeTrue())
220+
Expect(string(nbConfig.Protocol)).To(Equal(args.protocol))
221221
}
222222

223223
if args.proxyProtocol != "" {
224224
By("Checking for Proxy Protocol")
225-
Expect(string(nbConfig.ProxyProtocol) == args.proxyProtocol).Should(BeTrue())
225+
Expect(string(nbConfig.ProxyProtocol)).To(Equal(args.proxyProtocol))
226226
}
227227

228228
if args.checkNodes {

0 commit comments

Comments
 (0)