Remove circular definition of ProviderID

Author: okokes-akamai

cloud/linode/instances.go

@@ -92,7 +92,7 @@ func (i *instances) InstanceMetadata(ctx context.Context, node *v1.Node) (*cloud
 
 	// note that Zone is omitted as it's not a thing in Linode
 	meta := &cloudprovider.InstanceMetadata{
-		ProviderID:    node.Spec.ProviderID, // TODO(okokes): this is circular... should we instead set it to a known prefix + linode.ID?
+		ProviderID:    fmt.Sprintf("%v%v", providerIDPrefix, linode.ID),
 		NodeAddresses: addresses,
 		InstanceType:  linode.Type,
 		Region:        linode.Region,

cloud/linode/instances_test.go

@@ -144,6 +144,7 @@ func TestMetadataRetrieval(t *testing.T) {
 
 		meta, err := instances.InstanceMetadata(ctx, node)
 		assert.NoError(t, err)
+		assert.Equal(t, providerIDPrefix+strconv.Itoa(id), meta.ProviderID)
 		assert.Equal(t, region, meta.Region)
 		assert.Equal(t, linodeType, meta.InstanceType)
 		assert.Equal(t, meta.NodeAddresses, []v1.NodeAddress{