Explicitly return a found NB instead of looping

okokes-akamai · okokes-akamai · commit 0eb1f7d9d212 · 2023-03-14T16:44:03.000+01:00
diff --git a/cloud/linode/loadbalancers.go b/cloud/linode/loadbalancers.go
@@ -455,13 +455,11 @@ func (l *loadbalancers) getNodeBalancerByIPv4(ctx context.Context, service *v1.S
 	if err != nil {
 		return nil, err
 	}
-	for _, lb := range lbs {
-		if *lb.IPv4 == ipv4 {
-			klog.V(2).Infof("found NodeBalancer (%d) for service (%s) via IPv4 (%s)", lb.ID, getServiceNn(service), ipv4)
-			return &lb, nil
-		}
+	if len(lbs) == 0 {
+		return nil, lbNotFoundError{serviceNn: getServiceNn(service)}
 	}
-	return nil, lbNotFoundError{serviceNn: getServiceNn(service)}
+	klog.V(2).Infof("found NodeBalancer (%d) for service (%s) via IPv4 (%s)", lbs[0].ID, getServiceNn(service), ipv4)
+	return &lbs[0], nil
 }
 
 func (l *loadbalancers) getNodeBalancerByID(ctx context.Context, service *v1.Service, id int) (*linodego.NodeBalancer, error) {

Original file line number	Diff line number	Diff line change
`@@ -455,13 +455,11 @@ func (l loadbalancers) getNodeBalancerByIPv4(ctx context.Context, service v1.S`
`455`	`455`	`if err != nil {`
`456`	`456`	`return nil, err`
`457`	`457`	`}`
`458`		`- for _, lb := range lbs {`
`459`		`- if *lb.IPv4 == ipv4 {`
`460`		`- klog.V(2).Infof("found NodeBalancer (%d) for service (%s) via IPv4 (%s)", lb.ID, getServiceNn(service), ipv4)`
`461`		`- return &lb, nil`
`462`		`- }`
	`458`	`+ if len(lbs) == 0 {`
	`459`	`+ return nil, lbNotFoundError{serviceNn: getServiceNn(service)}`
`463`	`460`	`}`
`464`		`- return nil, lbNotFoundError{serviceNn: getServiceNn(service)}`
	`461`	`+ klog.V(2).Infof("found NodeBalancer (%d) for service (%s) via IPv4 (%s)", lbs[0].ID, getServiceNn(service), ipv4)`
	`462`	`+ return &lbs[0], nil`
`465`	`463`	`}`
`466`	`464`
`467`	`465`	`func (l loadbalancers) getNodeBalancerByID(ctx context.Context, service v1.Service, id int) (*linodego.NodeBalancer, error) {`