From d126a4b2b20390f445531cc2a6070cb429abad21 Mon Sep 17 00:00:00 2001 From: Brandonma21 Date: Tue, 27 Oct 2026 09:19:27 +0200 Subject: [PATCH 1/3] fix: hero-breadcrumbs - Tighten the breadcrumb gap under the header on the spacing 90, 100 and 60 heroes (batch 2 of 2) Hero patterns - Lower the outer section's top padding to spacing 40, so the breadcrumb sits 26px below the header - Spacing 100 (64px): hero-centered-gradient-title, page-hero and the thank-you-confirmation section - Spacing 90 (56px): search-hero, services-hero and solutions-hero - Spacing 60 (37px): phase-hero and service-hero - The breadcrumb is the first element in each, so the whole hero moves up by the same amount - Every hero with a breadcrumb now uses the same value as the blog hero and batch 1 Docs - Add the CHANGELOG.md entry under Unreleased - Mark the batch 2 line done in task-list.md Scope - The shared breadcrumbs pattern stays at 20px - Pages built from these patterns keep their own copy of the hero in the database, so they change only when their saved markup is updated Testing - Local: 22 pages re-attached to the new padding, and all 25 pages and templates measured, including search, solutions and the legal page, show a 26px gap at 1440px - An audit of the patterns shows every hero at 26px - Accessibility, runtime errors and horizontal overflow pass on /services/discovery/, /about/process/, /solutions/, /privacy-policy/ and search, in chromium and Mobile Chrome - /services/ also passes all four standing specs after its saved button row was brought up to date locally with the ls-buttons-wrap class the pattern already has (a database change, not part of this commit) - php -l passes on all 8 patterns - Not yet verified on DEV, whose pages still hold the old copies --- .github/tasks/task-list.md | 2 +- CHANGELOG.md | 9 +++++++++ patterns/hero/hero-centered-gradient-title.php | 4 ++-- patterns/hero/page-hero.php | 4 ++-- patterns/hero/phase-hero.php | 4 ++-- patterns/hero/search-hero.php | 4 ++-- patterns/hero/service-hero.php | 4 ++-- patterns/hero/services-hero.php | 4 ++-- patterns/hero/solutions-hero.php | 4 ++-- patterns/sections/thank-you-confirmation.php | 4 ++-- 10 files changed, 26 insertions(+), 17 deletions(-) diff --git a/.github/tasks/task-list.md b/.github/tasks/task-list.md index d930ee53..e5848c73 100644 --- a/.github/tasks/task-list.md +++ b/.github/tasks/task-list.md @@ -25,7 +25,7 @@ Update this file as tasks are created, started, or completed. - [x] Implement Sass mixin structure and compiled CSS workflow for authored theme effects - [x] Align the header to the content width, centre the mega menus, hide Pricing and close the blog hero gaps (BugHerd #268, #269, #270) - [x] Tighten the breadcrumb gap under the header on the spacing 80 heroes (hero breadcrumb batch 1 of 2, pattern sources only; saved pages update separately) -- [ ] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2) +- [x] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2) - [ ] Build `parts/header.html` - [ ] Build `parts/footer.html` - [ ] Build `templates/index.html` diff --git a/CHANGELOG.md b/CHANGELOG.md index 4da6e7a8..3fe8865c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 --- +## [Unreleased] — Tighten the breadcrumb gap under the header, batch 2: the spacing 90, 100 and 60 heroes + +### Fixed + +- The gap between the header and the breadcrumb on the remaining heroes was too large: 64px on `hero-centered-gradient-title`, `page-hero` and the `thank-you-confirmation` section (`spacing|100`), 56px on `search-hero`, `services-hero` and `solutions-hero` (`spacing|90`), and 37px on `phase-hero` and `service-hero` (`spacing|60`). Their outer section's top padding is now `spacing|40` (26px), the same value used on the blog hero and in batch 1, so every hero with a breadcrumb now matches. The breadcrumb is the first element in each, so the whole hero moves up by the same amount. +- Pages built from these patterns hold their own copy of the hero in the database, so they only change once their saved markup is updated. + +--- + ## [Unreleased] — Tighten the breadcrumb gap under the header, batch 1: the spacing 80 heroes ### Fixed diff --git a/patterns/hero/hero-centered-gradient-title.php b/patterns/hero/hero-centered-gradient-title.php index cca23f2a..ec9123fa 100644 --- a/patterns/hero/hero-centered-gradient-title.php +++ b/patterns/hero/hero-centered-gradient-title.php @@ -13,8 +13,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/page-hero.php b/patterns/hero/page-hero.php index 97f411ef..86fb73b6 100644 --- a/patterns/hero/page-hero.php +++ b/patterns/hero/page-hero.php @@ -13,8 +13,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/phase-hero.php b/patterns/hero/phase-hero.php index f9dce460..3825e935 100644 --- a/patterns/hero/phase-hero.php +++ b/patterns/hero/phase-hero.php @@ -25,8 +25,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/search-hero.php b/patterns/hero/search-hero.php index 0607789f..51c0d216 100644 --- a/patterns/hero/search-hero.php +++ b/patterns/hero/search-hero.php @@ -22,8 +22,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/service-hero.php b/patterns/hero/service-hero.php index 17976209..db3ac40e 100644 --- a/patterns/hero/service-hero.php +++ b/patterns/hero/service-hero.php @@ -41,8 +41,8 @@ $ls_glance_border = 'color-mix(in srgb, var(--wp--custom--color--text--on-dark) 16%, transparent)'; ?> - -
+ +
diff --git a/patterns/hero/services-hero.php b/patterns/hero/services-hero.php index 13fc2964..f99179b5 100644 --- a/patterns/hero/services-hero.php +++ b/patterns/hero/services-hero.php @@ -124,8 +124,8 @@ ), ); ?> - -
+ +
diff --git a/patterns/hero/solutions-hero.php b/patterns/hero/solutions-hero.php index bfc340fd..0c26ad80 100644 --- a/patterns/hero/solutions-hero.php +++ b/patterns/hero/solutions-hero.php @@ -15,8 +15,8 @@ // Swatch order matches the modifier classes in src/scss/structural/solutions-hero.scss. $ls_solutions_hero_swatches = array( 'brand', 'violet', 'cyan', 'orange' ); ?> - -
+ +
diff --git a/patterns/sections/thank-you-confirmation.php b/patterns/sections/thank-you-confirmation.php index 143b2ad7..e81eb520 100644 --- a/patterns/sections/thank-you-confirmation.php +++ b/patterns/sections/thank-you-confirmation.php @@ -42,8 +42,8 @@ ), ); ?> - -
+ +
From b88c0d596cfe66b4753f8223f55d3caeab4028f6 Mon Sep 17 00:00:00 2001 From: Brandonma21 Date: Tue, 27 Oct 2026 09:23:34 +0200 Subject: [PATCH 2/3] docs: changelog - Link the breadcrumb batch 2 entry to its PR Changelog - Add the PR #170 link to the batch 2 entry Co-Authored-By: Claude Sonnet 5.5 --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3fe8865c..0794d26c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - The gap between the header and the breadcrumb on the remaining heroes was too large: 64px on `hero-centered-gradient-title`, `page-hero` and the `thank-you-confirmation` section (`spacing|100`), 56px on `search-hero`, `services-hero` and `solutions-hero` (`spacing|90`), and 37px on `phase-hero` and `service-hero` (`spacing|60`). Their outer section's top padding is now `spacing|40` (26px), the same value used on the blog hero and in batch 1, so every hero with a breadcrumb now matches. The breadcrumb is the first element in each, so the whole hero moves up by the same amount. - Pages built from these patterns hold their own copy of the hero in the database, so they only change once their saved markup is updated. +([#170](https://github.com/lightspeedwp/ls-theme/pull/170)) + --- ## [Unreleased] — Tighten the breadcrumb gap under the header, batch 1: the spacing 80 heroes From 54d40db41a62ad6cd4f60bba48d8a82e4da1010b Mon Sep 17 00:00:00 2001 From: Brandonma21 Date: Tue, 27 Oct 2026 09:45:36 +0200 Subject: [PATCH 3/3] docs: task-list - Scope hero breadcrumb batch 2 to the pattern sources Context - CodeRabbit noted batch 2 lacked the scope note batch 1 has Docs fix - Note the task covers pattern sources only - Saved pages update separately from their own markup Co-Authored-By: Claude Sonnet 5.5 --- .github/tasks/task-list.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/tasks/task-list.md b/.github/tasks/task-list.md index e5848c73..8b715833 100644 --- a/.github/tasks/task-list.md +++ b/.github/tasks/task-list.md @@ -25,7 +25,7 @@ Update this file as tasks are created, started, or completed. - [x] Implement Sass mixin structure and compiled CSS workflow for authored theme effects - [x] Align the header to the content width, centre the mega menus, hide Pricing and close the blog hero gaps (BugHerd #268, #269, #270) - [x] Tighten the breadcrumb gap under the header on the spacing 80 heroes (hero breadcrumb batch 1 of 2, pattern sources only; saved pages update separately) -- [x] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2) +- [x] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2, pattern sources only; saved pages update separately) - [ ] Build `parts/header.html` - [ ] Build `parts/footer.html` - [ ] Build `templates/index.html`