diff --git a/.github/tasks/task-list.md b/.github/tasks/task-list.md index d930ee5..8b71583 100644 --- a/.github/tasks/task-list.md +++ b/.github/tasks/task-list.md @@ -25,7 +25,7 @@ Update this file as tasks are created, started, or completed. - [x] Implement Sass mixin structure and compiled CSS workflow for authored theme effects - [x] Align the header to the content width, centre the mega menus, hide Pricing and close the blog hero gaps (BugHerd #268, #269, #270) - [x] Tighten the breadcrumb gap under the header on the spacing 80 heroes (hero breadcrumb batch 1 of 2, pattern sources only; saved pages update separately) -- [ ] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2) +- [x] Tighten the breadcrumb gap on the spacing 90, 100 and 60 heroes (hero breadcrumb batch 2 of 2, pattern sources only; saved pages update separately) - [ ] Build `parts/header.html` - [ ] Build `parts/footer.html` - [ ] Build `templates/index.html` diff --git a/CHANGELOG.md b/CHANGELOG.md index 4da6e7a..0794d26 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 --- +## [Unreleased] — Tighten the breadcrumb gap under the header, batch 2: the spacing 90, 100 and 60 heroes + +### Fixed + +- The gap between the header and the breadcrumb on the remaining heroes was too large: 64px on `hero-centered-gradient-title`, `page-hero` and the `thank-you-confirmation` section (`spacing|100`), 56px on `search-hero`, `services-hero` and `solutions-hero` (`spacing|90`), and 37px on `phase-hero` and `service-hero` (`spacing|60`). Their outer section's top padding is now `spacing|40` (26px), the same value used on the blog hero and in batch 1, so every hero with a breadcrumb now matches. The breadcrumb is the first element in each, so the whole hero moves up by the same amount. +- Pages built from these patterns hold their own copy of the hero in the database, so they only change once their saved markup is updated. + +([#170](https://github.com/lightspeedwp/ls-theme/pull/170)) + +--- + ## [Unreleased] — Tighten the breadcrumb gap under the header, batch 1: the spacing 80 heroes ### Fixed diff --git a/patterns/hero/hero-centered-gradient-title.php b/patterns/hero/hero-centered-gradient-title.php index cca23f2..ec9123f 100644 --- a/patterns/hero/hero-centered-gradient-title.php +++ b/patterns/hero/hero-centered-gradient-title.php @@ -13,8 +13,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/page-hero.php b/patterns/hero/page-hero.php index 97f411e..86fb73b 100644 --- a/patterns/hero/page-hero.php +++ b/patterns/hero/page-hero.php @@ -13,8 +13,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/phase-hero.php b/patterns/hero/phase-hero.php index f9dce46..3825e93 100644 --- a/patterns/hero/phase-hero.php +++ b/patterns/hero/phase-hero.php @@ -25,8 +25,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/search-hero.php b/patterns/hero/search-hero.php index 0607789..51c0d21 100644 --- a/patterns/hero/search-hero.php +++ b/patterns/hero/search-hero.php @@ -22,8 +22,8 @@ */ ?> - -
+ +
diff --git a/patterns/hero/service-hero.php b/patterns/hero/service-hero.php index 1797620..db3ac40 100644 --- a/patterns/hero/service-hero.php +++ b/patterns/hero/service-hero.php @@ -41,8 +41,8 @@ $ls_glance_border = 'color-mix(in srgb, var(--wp--custom--color--text--on-dark) 16%, transparent)'; ?> - -
+ +
diff --git a/patterns/hero/services-hero.php b/patterns/hero/services-hero.php index 13fc296..f99179b 100644 --- a/patterns/hero/services-hero.php +++ b/patterns/hero/services-hero.php @@ -124,8 +124,8 @@ ), ); ?> - -
+ +
diff --git a/patterns/hero/solutions-hero.php b/patterns/hero/solutions-hero.php index bfc340f..0c26ad8 100644 --- a/patterns/hero/solutions-hero.php +++ b/patterns/hero/solutions-hero.php @@ -15,8 +15,8 @@ // Swatch order matches the modifier classes in src/scss/structural/solutions-hero.scss. $ls_solutions_hero_swatches = array( 'brand', 'violet', 'cyan', 'orange' ); ?> - -
+ +
diff --git a/patterns/sections/thank-you-confirmation.php b/patterns/sections/thank-you-confirmation.php index 143b2ad..e81eb52 100644 --- a/patterns/sections/thank-you-confirmation.php +++ b/patterns/sections/thank-you-confirmation.php @@ -42,8 +42,8 @@ ), ); ?> - -
+ +