feat: bump to 4.30#141
Merged
Merged
Conversation
two adaptations (and the remaining defeq abuse options) to be investigated.
- disable mathlib's header linter, - the flexible linter is the default in mathlib now
fpvandoorn
reviewed
Jun 2, 2026
fpvandoorn
left a comment
fpvandoorn
left a comment
Member
There was a problem hiding this comment.
One minor comment, otherwise LGTM
| [[require]] | ||
| name = "mathlib" | ||
| scope = "leanprover-community" | ||
| rev = "v4.30.0" |
Member
There was a problem hiding this comment.
Do we want to hardcode this? Remove?
Collaborator
Author
There was a problem hiding this comment.
I think it's nice if the 4.30 tag on this repository corresponds to that version of mathlib --- so yes, this is intentional for this PR. A follow-up can bump to current mathlib and remove the tag, or in the future bump to 4.31, etc.
Member
There was a problem hiding this comment.
I agree, but after lake-manifest.json has the correct hashes (by adding this to lakefile.toml and running lake update), is there a point in not reverting the change to lakefile.toml in the same PR? But it also seems fine to do this in a follow-up PR instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to add 40
set_option backward.isDefEq.respectTransparency false ins.One
simpbroke, but there is a not too bad fix. (I still it were better understood.)One proof now takes a really long time; it would be good to understand why!