change favorite button pressed protocol

Author: lauramarson

AnimalsApp/AnimalsApp/View Models/HomeViewModel.swift

@@ -59,14 +59,16 @@ class HomeViewModel {
         }
     }
 
-    func addOrRemoveFavorite(at index: Int, with image: Data) {
+    func removeFavorite(at index: Int) {
+        guard let id = animals[index].id else { return }
+        coreData.removeFavorite(id: id)
+        animals[index].isFavorite = false
+    }
+    
+    func addFavorite(at index: Int, with image: Data) {
         animals[index].imageData = image
-        
-        guard let isFavorite = animals[index].isFavorite,
-              let id = animals[index].id else { return }
-        isFavorite ? coreData.removeFavorite(id: id) : coreData.addFavorite(animals[index])
-        
-        animals[index].isFavorite = !isFavorite
+        coreData.addFavorite(animals[index])
+        animals[index].isFavorite = true
     }
 
     func loadFavorites(completion: @escaping () -> ()) {

AnimalsApp/AnimalsApp/Views/Components/AnimalTableViewCell.swift

@@ -9,7 +9,8 @@ import UIKit
 import SDWebImage
 
 protocol ActionDelegateProtocol: AnyObject {
-    func favoriteButtonTapped(at index: Int, with image: Data)
+    func addFavoriteTapped(at index: Int, with image: Data)
+    func removeFavoriteTapped(at index: Int)
 }
 
 class AnimalTableViewCell: UITableViewCell {
@@ -57,21 +58,18 @@ class AnimalTableViewCell: UITableViewCell {
     }
 
     @IBAction func favoritePressed(_ sender: UIButton) {
-        guard let animal = animal else { return }
+        guard let animal = animal, let index = index else { return }
 
         if animal.isFavorite ?? false {
             sender.setImage(.notFavorite, for: .normal)
             self.animal?.isFavorite = false
+            delegate?.removeFavoriteTapped(at: index)
         } else {
             sender.setImage(.favorite, for: .normal)
             self.animal?.isFavorite = true
-        }
-        
-        let image = SDImageCache.shared.imageFromDiskCache(forKey: animal.imageURL.absoluteString)
-        
-        if let index = index {
+            let image = SDImageCache.shared.imageFromDiskCache(forKey: animal.imageURL.absoluteString)
             let imageData = image?.jpegData(compressionQuality: 0.9)
-            delegate?.favoriteButtonTapped(at: index, with: imageData ?? Data())
+            delegate?.addFavoriteTapped(at: index, with: imageData ?? Data())
         }
     }
 }

AnimalsApp/AnimalsApp/Views/FavoritesViewController/FavoritesViewController.swift

@@ -86,7 +86,10 @@ extension FavoritesViewController: UITableViewDelegate {
 
 // MARK: Action Delegate Protocol
 extension FavoritesViewController: ActionDelegateProtocol {
-    func favoriteButtonTapped(at index: Int, with image: Data) {
+    func addFavoriteTapped(at index: Int, with image: Data) {
+    }
+    
+    func removeFavoriteTapped(at index: Int) {
         favoritesVM?.removeFavorite(at: index) { [weak self] in
             self?.tableView.reloadData()
         }

AnimalsApp/AnimalsApp/Views/HomeViewController/HomeViewController.swift

@@ -124,7 +124,11 @@ extension HomeViewController: UITableViewDelegate {
 
 // MARK: Action Delegate Protocol
 extension HomeViewController: ActionDelegateProtocol {
-    func favoriteButtonTapped(at index: Int, with image: Data) {
-        homeVM.addOrRemoveFavorite(at: index, with: image)
-    }    
+    func addFavoriteTapped(at index: Int, with image: Data) {
+        homeVM.addFavorite(at: index, with: image)
+    }
+    
+    func removeFavoriteTapped(at index: Int) {
+        homeVM.removeFavorite(at: index)
+    }   
 }