Fix GraphQL parser to handle renamed objects correctly (#2670)

* init

* fix

* Fix snapshots

* use unique=False

* Add conflict test

* modify references logic

* fix docstring

* revert name change

* Exclude else branch from coverage

---------

Co-authored-by: Koudai Aono <koxudaxi@gmail.com>

Author: siminn-arnorgj

src/datamodel_code_generator/parser/graphql.py

@@ -484,12 +484,11 @@ def parse_field(
             obj = graphql.assert_wrapping_type(obj)
             obj = obj.of_type
 
-        if graphql.is_enum_type(obj):
-            obj = graphql.assert_enum_type(obj)
-            data_type.reference = self.references[obj.name]
-
         obj = graphql.assert_named_type(obj)
-        if data_type.reference is None:
+        if obj.name in self.references:
+            data_type.reference = self.references[obj.name]
+        else:  # pragma: no cover
+            # Only happens for Query and Mutation root types
             data_type.type = obj.name
 
         required = (not self.force_optional_for_required_fields) and (not final_data_type.is_optional)

tests/data/expected/main/graphql/casing.py

@@ -0,0 +1,59 @@
+# generated by datamodel-codegen:
+#   filename:  casing.graphql
+#   timestamp: 2019-07-26T00:00:00+00:00
+
+from __future__ import annotations
+
+from enum import Enum
+from typing import Literal, Optional
+
+from pydantic import BaseModel, Field
+from typing_extensions import TypeAlias
+
+Boolean: TypeAlias = bool
+"""
+The `Boolean` scalar type represents `true` or `false`.
+"""
+
+
+Int: TypeAlias = int
+"""
+The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1.
+"""
+
+
+String: TypeAlias = str
+"""
+The `String` scalar type represents textual data, represented as UTF-8 character sequences. The String type is most often used by GraphQL to represent free-form human-readable text.
+"""
+
+
+class Lowercase(Enum):
+    foo = 'foo'
+
+
+class Conflict(BaseModel):
+    Bar: Int
+    bar: String
+    typename__: Optional[Literal['Conflict']] = Field('Conflict', alias='__typename')
+
+
+class ConflictModel(BaseModel):
+    Foo: Int
+    foo: String
+    typename__: Optional[Literal['conflict']] = Field('conflict', alias='__typename')
+
+
+class Lowercasetype(BaseModel):
+    foo: Int
+    typename__: Optional[Literal['lowercasetype']] = Field(
+        'lowercasetype', alias='__typename'
+    )
+
+
+class Ref(BaseModel):
+    bar: Lowercase
+    baz: Lowercasetype
+    eggs: Conflict
+    spam: ConflictModel
+    typename__: Optional[Literal['Ref']] = Field('Ref', alias='__typename')

tests/data/expected/main/graphql/enum_casing.py

@@ -153,3 +153,7 @@ class Vehicle(BaseModel):
     pilots_ids: List[ID]
     vehicle_class: Optional[String] = None
     typename__: Optional[Literal['Vehicle']] = Field('Vehicle', alias='__typename')
+
+
+Film.update_forward_refs()
+Person.update_forward_refs()

tests/data/expected/main/graphql/simple_star_wars.py

@@ -171,3 +171,7 @@ class Config:
     pilots_ids: List[ID]
     vehicle_class: Optional[String] = None
     typename__: Optional[Literal['Vehicle']] = Field('Vehicle', alias='__typename')
+
+
+Film.update_forward_refs()
+Person.update_forward_refs()

tests/data/expected/main/graphql/simple_star_wars_extra_fields_allow.py

@@ -30,15 +30,6 @@
 """
 
 
-class ModelWithTypeAliasField(BaseModel):
-    simple_field: Optional[SimpleString] = None
-    string_field: Optional[String] = None
-    union_field: Optional[UnionType] = None
-    typename__: Optional[Literal['ModelWithTypeAliasField']] = Field(
-        'ModelWithTypeAliasField', alias='__typename'
-    )
-
-
 class Person(BaseModel):
     age: Int
     name: String
@@ -55,3 +46,12 @@ class Pet(BaseModel):
     'Person',
     'Pet',
 ]
+
+
+class ModelWithTypeAliasField(BaseModel):
+    simple_field: Optional[SimpleString] = None
+    string_field: Optional[String] = None
+    union_field: Optional[UnionType] = None
+    typename__: Optional[Literal['ModelWithTypeAliasField']] = Field(
+        'ModelWithTypeAliasField', alias='__typename'
+    )

tests/data/expected/main/graphql/type_alias.py

@@ -29,15 +29,6 @@
 """
 
 
-class ModelWithTypeAliasField(BaseModel):
-    simple_field: Optional[SimpleString] = None
-    string_field: Optional[String] = None
-    union_field: Optional[UnionType] = None
-    typename__: Optional[Literal['ModelWithTypeAliasField']] = Field(
-        'ModelWithTypeAliasField', alias='__typename'
-    )
-
-
 class Person(BaseModel):
     age: Int
     name: String
@@ -54,3 +45,12 @@ class Pet(BaseModel):
     'Person',
     'Pet',
 ]
+
+
+class ModelWithTypeAliasField(BaseModel):
+    simple_field: Optional[SimpleString] = None
+    string_field: Optional[String] = None
+    union_field: Optional[UnionType] = None
+    typename__: Optional[Literal['ModelWithTypeAliasField']] = Field(
+        'ModelWithTypeAliasField', alias='__typename'
+    )

tests/data/expected/main/graphql/type_alias_py312.py

@@ -28,11 +28,6 @@ class GroupMetadata(BaseModel):
     )
 
 
-class Resource(BaseModel):
-    metadata: UserMetadata
-    typename__: Optional[Literal['Resource']] = Field('Resource', alias='__typename')
-
-
 class UserMetadata(BaseModel):
     name: String
     typename__: Optional[Literal['UserMetadata']] = Field(
@@ -44,3 +39,8 @@ class UserMetadata(BaseModel):
     'GroupMetadata',
     'UserMetadata',
 ]
+
+
+class Resource(BaseModel):
+    metadata: UserMetadata
+    typename__: Optional[Literal['Resource']] = Field('Resource', alias='__typename')

tests/data/expected/parser/graphql/union-aliased-bug.py

@@ -32,11 +32,6 @@ class GroupMetadata(BaseModel):
     )
 
 
-class Resource(BaseModel):
-    metadata: UserMetadata
-    typename__: Optional[Literal['Resource']] = Field('Resource', alias='__typename')
-
-
 class UserMetadata(BaseModel):
     """
     This is a multiline comment,
@@ -64,3 +59,8 @@ class UserMetadata(BaseModel):
     'GroupMetadata',
     'UserMetadata',
 ]
+
+
+class Resource(BaseModel):
+    metadata: UserMetadata
+    typename__: Optional[Literal['Resource']] = Field('Resource', alias='__typename')

tests/data/expected/parser/graphql/union-commented.py

@@ -0,0 +1,24 @@
+enum lowercase {
+  foo
+}
+
+type lowercasetype {
+  foo: Int!
+}
+
+type conflict {
+  foo: String!
+  Foo: Int!
+}
+
+type Conflict {
+  bar: String!
+  Bar: Int!
+}
+
+type Ref {
+  bar: lowercase!
+  baz: lowercasetype!
+  spam: conflict!
+  eggs: Conflict!
+}