[FEATURE] Add a tenant setup CLI command#1980
Open
csidirop wants to merge 3 commits into
Open
Conversation
Signed-off-by: Christos Sidiropoulos <dev@csidirop.de>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| This installation already includes a working viewer page and a prepared configuration folder. | ||
| </p> | ||
|
|
||
| <form class="tx-dlf-default-viewer-input-form" action="{f:uri.page(pageUid: viewerPid)}" method="get" onsubmit="var input=this.querySelector('input[name='tx_dlf[id]']'); if(input){ input.value=input.value.trim(); }"> |
Signed-off-by: Christos Sidiropoulos <dev@csidirop.de>
csidirop
force-pushed
the
feat/tenant-setup-cli
branch
2 times, most recently
from
365afd3 to
009d389
Compare
Signed-off-by: Christos Sidiropoulos <dev@csidirop.de>
csidirop
force-pushed
the
feat/tenant-setup-cli
branch
from
009d389 to
755eb98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new tenant setup flow, which does exaclty the same as the original new tenant backend module but is accessible through a new CLI command.
It introduces a dedicated CLI command for applying tenant defaults to an existing configuration folder and refactors the backend new-tenant module so that both use the same shared setup logic and future changes affect both.
This PR builds on top of:
Changes
kitodo:tenantSetup --config-page=<uid>for all--namespaces--structures--metadataTenantModuleSetupServiceTenantDefaultsSetupService--namespaces--formatsas alias for--namespaces--structures--metadata--solr-coreNew Tenant module refactor
This PR moves significant parts out of the original
NewTenantController. I did not find a nice other way.Because the tenant setup logic is now shared between the backend module and the CLI command, it makes sense to extract that logic into shared services. The
NewTenantControllernow acts as a coordinator that delegates to those services.NewTenantControlleracts as a coordinatorTenantDefaultsSetupServiceThis hopefully keeps the backend and CLI behavior aligned and avoids maintaining two separate implementations of the same setup steps.