Skip to content

Commit 2663fd5

Browse files
committed
fix(tests): use py3.6-compatible subprocess.run kwargs
capture_output and text were added in Python 3.7; CI runs 3.6, so TestTokenTableGenerators failed with TypeError on every case before the test body ran.
1 parent f01c36d commit 2663fd5

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

tests/test_token_table_generators.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ def _run(self, script):
5656
out = os.path.join(tmp, 'out.def')
5757
proc = subprocess.run(
5858
[sys.executable, os.path.join(_ETH, script), out],
59-
capture_output=True, text=True, cwd=_PYKEEPKEY)
59+
stdout=subprocess.PIPE, stderr=subprocess.PIPE,
60+
universal_newlines=True, cwd=_PYKEEPKEY)
6061
self.assertEqual(
6162
proc.returncode, 0,
6263
'%s exited %d -- the firmware build runs this exact command '

0 commit comments

Comments
 (0)