Skip to content

Commit 49f6742

Browse files
Oscar-XXIIclaude
andcommitted
CFTL-589 Drop the conditional URL patterns: allOf breaks the auth radio
Confirmed in the Ctrl+D sandbox — with the allOf block present, the GitHub OAuth option disappears from the authentication radio entirely. This is the known RJSF allOf merge failure (rjsf-team/react-jsonschema-form#2752, #3445), which reports exactly this symptom: "could not merge subschemas in allOf: Could not resolve values for path: properties.value.enum". The if clauses mention properties.auth, so the merge narrows the enum it was only meant to test against. The schema itself was always valid — the eight and thirteen case runs that justified this passed. They were run with the jsonschema library, which validates but does not render, and the renderer is where this breaks. Validating semantics is not evidence about the form. Conditional validation is therefore off the table in this UI, whatever the standard permits: url stays plainly required with minLength: 1, and the auth specific URL rules stay in source_git.py where they already have clear messages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent bf6a528 commit 49f6742

1 file changed

Lines changed: 0 additions & 59 deletions

File tree

‎component_config/configSchema.json‎

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -112,65 +112,6 @@
112112
"auth",
113113
"url"
114114
],
115-
"allOf": [
116-
{
117-
"if": {
118-
"properties": {
119-
"auth": {
120-
"const": "oauth"
121-
}
122-
},
123-
"required": [
124-
"auth"
125-
]
126-
},
127-
"then": {
128-
"properties": {
129-
"url": {
130-
"pattern": "^https://(www\\.)?github\\.com/.+"
131-
}
132-
}
133-
}
134-
},
135-
{
136-
"if": {
137-
"properties": {
138-
"auth": {
139-
"const": "pat"
140-
}
141-
},
142-
"required": [
143-
"auth"
144-
]
145-
},
146-
"then": {
147-
"properties": {
148-
"url": {
149-
"pattern": "^https://.+"
150-
}
151-
}
152-
}
153-
},
154-
{
155-
"if": {
156-
"properties": {
157-
"auth": {
158-
"const": "ssh"
159-
}
160-
},
161-
"required": [
162-
"auth"
163-
]
164-
},
165-
"then": {
166-
"properties": {
167-
"url": {
168-
"pattern": "^(git@|ssh://).+"
169-
}
170-
}
171-
}
172-
}
173-
],
174115
"properties": {
175116
"auth": {
176117
"type": "string",

0 commit comments

Comments
 (0)