Commit 49f6742
CFTL-589 Drop the conditional URL patterns: allOf breaks the auth radio
Confirmed in the Ctrl+D sandbox — with the allOf block present, the GitHub OAuth
option disappears from the authentication radio entirely. This is the known RJSF
allOf merge failure (rjsf-team/react-jsonschema-form#2752, #3445), which reports
exactly this symptom: "could not merge subschemas in allOf: Could not resolve
values for path: properties.value.enum". The if clauses mention properties.auth,
so the merge narrows the enum it was only meant to test against.
The schema itself was always valid — the eight and thirteen case runs that
justified this passed. They were run with the jsonschema library, which validates
but does not render, and the renderer is where this breaks. Validating semantics
is not evidence about the form.
Conditional validation is therefore off the table in this UI, whatever the
standard permits: url stays plainly required with minLength: 1, and the auth
specific URL rules stay in source_git.py where they already have clear messages.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent bf6a528 commit 49f6742
1 file changed
Lines changed: 0 additions & 59 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 115 | | |
175 | 116 | | |
176 | 117 | | |
| |||
0 commit comments