Skip to content

Commit 30545f8

Browse files
committed
Updates for v2 arch
1 parent 9e6a85c commit 30545f8

4 files changed

Lines changed: 15 additions & 14 deletions

File tree

src/main/java/org/hdf5javalib/dataclass/reference/HdfObjectReference.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public HdfObjectReference(byte[] bytes, ReferenceDatatype dt, boolean external)
107107
// }
108108
// Collections.reverse(parents);
109109
// String objectPathString = '/' + currentNode.getObjectName() + String.join("/", parents);
110-
String objectPathString = HdfDisplayUtils.getDataObjectFullName(hdfDataObject);
110+
String objectPathString = hdfDataObject.getObjectPath();
111111

112112
this.hdfDataHolder = HdfDataHolder.ofScalar(
113113
new HdfString(objectPathString, new StringDatatype(

src/main/java/org/hdf5javalib/hdfjava/HdfDataObject.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public String getObjectPath() {
4242
path.insert(0, parent.getObjectName());
4343
parent=parent.getParent();
4444
}
45+
path.insert(0, '/');
4546
return path.toString();
4647
}
4748

src/main/java/org/hdf5javalib/hdfjava/HdfFileReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ private void readV2Arch(SeekableByteChannel fileChannel, HdfGroup rootGroup) thr
210210
if ( objectHeader != null && objectHeader.findMessageByType(DataLayoutMessage.class).isEmpty() ) {
211211
HdfGroup groupObject = new HdfGroup(groupName, objectHeader, rootGroup, hardLink);
212212
rootGroup.addChild(groupObject);
213-
System.out.println("ADDED GROUP: " + HdfDisplayUtils.getDataObjectFullName(groupObject));
213+
System.out.println("ADDED GROUP: " + groupObject.getObjectPath());
214214

215215
if ( hardLink == null ) {
216216
LinkInfoMessage linkInfoMessage = objectHeader.findMessageByType(LinkInfoMessage.class).orElseThrow();
@@ -222,7 +222,7 @@ private void readV2Arch(SeekableByteChannel fileChannel, HdfGroup rootGroup) thr
222222
} else {
223223
HdfDataset datasetObject = new HdfDataset(groupName, objectHeader, rootGroup, hardLink);
224224
rootGroup.addChild(datasetObject);
225-
System.out.println("ADDED DATASET: " + HdfDisplayUtils.getDataObjectFullName(datasetObject));
225+
System.out.println("ADDED DATASET: " + datasetObject.getObjectPath());
226226
}
227227

228228

src/main/java/org/hdf5javalib/utils/HdfDisplayUtils.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -94,17 +94,17 @@ public static void displayAttributes(HdfDataset dataSet) throws InvocationTarget
9494
}
9595
}
9696

97-
public static String getDataObjectFullName(HdfDataObject hdfDataObject) {
98-
List<String> parents = new ArrayList<>();
99-
HdfDataObject currentNode = hdfDataObject;
100-
while(currentNode.getParent() != null) {
101-
parents.add(currentNode.getObjectName());
102-
currentNode = currentNode.getParent().getDataObject();
103-
}
104-
Collections.reverse(parents);
105-
String objectPathString = '/' + currentNode.getObjectName() + String.join("/", parents);
106-
return objectPathString;
107-
}
97+
// public static String getDataObjectFullName(HdfDataObject hdfDataObject) {
98+
// List<String> parents = new ArrayList<>();
99+
// HdfDataObject currentNode = hdfDataObject;
100+
// while(currentNode.getParent() != null) {
101+
// parents.add(currentNode.getObjectName());
102+
// currentNode = currentNode.getParent().getDataObject();
103+
// }
104+
// Collections.reverse(parents);
105+
// String objectPathString = '/' + currentNode.getObjectName() + String.join("/", parents);
106+
// return objectPathString;
107+
// }
108108

109109
public static void displayData(SeekableByteChannel channel, HdfDataset ds, HdfFileReader reader) throws Exception {
110110
log.debug("Dataset path: {}", ds.getObjectPath());

0 commit comments

Comments
 (0)