sonarqube cleanup.

Author: karlnicholas

src/main/java/org/hdf5javalib/dataclass/reference/HdfObjectReference.java

@@ -15,10 +15,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.List;
+import java.util.*;
 import java.util.concurrent.atomic.AtomicReference;
 
 public class HdfObjectReference implements HdfReferenceInstance {
@@ -125,7 +122,7 @@ public String toString() {
                 + "\r\n\treferenceType=" + referenceType.getDescription()
                 + "\r\n\thdfDataObject=" + (hdfDataObject == null ? "ObjectId not decoded" : "ObjectName: " + hdfDataObject.getObjectName())
                 + (referenceType.getValue() > ReferenceDatatype.ReferenceType.DATASET_REGION1.getValue() ?
-                "\r\n\tdataspaceSelectionInstance=" + (dataspaceSelectionInstance == null ? "no Dataspace Selection" : dataspaceSelectionInstance)
+                "\r\n\tdataspaceSelectionInstance=" + (Objects.requireNonNullElse(dataspaceSelectionInstance, "no Dataspace Selection"))
                 : "")
                 + "\r\n]";
 

src/main/java/org/hdf5javalib/datatype/CompoundDatatype.java

@@ -313,11 +313,7 @@ public <T> T getInstance(Class<T> clazz, byte[] bytes) throws InvocationTargetEx
 
         // Fall back to toPOJO for non-primitive, unregistered types
         if (!clazz.isPrimitive()) {
-//            try {
-                return toPOJO(clazz, bytes);
-//            } catch (Exception e) {
-//                throw new IllegalArgumentException("Failed to convert to POJO: " + clazz, e);
-//            }
+            return toPOJO(clazz, bytes);
         }
 
         throw new UnsupportedOperationException("Unknown type: " + clazz);
@@ -345,17 +341,13 @@ public <T> T toPOJO(Class<T> clazz, byte[] bytes) throws InvocationTargetExcepti
         // Get cached member map (instance-level cache since members are per-instance)
         Map<String, CompoundMemberDatatype> nameToMemberMap = getCachedMemberMap();
 
-//        try {
-            T instance;
-            if (clazz.isRecord()) {
-                instance = createRecordInstance(clazz, bytes, nameToMemberMap);
-            } else {
-                instance = createClassInstance(clazz, bytes, nameToFieldMap, nameToMemberMap);
-            }
-            return instance;
-//        } catch (Exception e) {
-//            throw new IllegalStateException("Failed to create instance of " + clazz.getName(), e);
-//        }
+        T instance;
+        if (clazz.isRecord()) {
+            instance = createRecordInstance(clazz, bytes, nameToMemberMap);
+        } else {
+            instance = createClassInstance(clazz, bytes, nameToFieldMap, nameToMemberMap);
+        }
+        return instance;
     }
 
     // Helper method to get cached member map

src/main/java/org/hdf5javalib/datatype/CompoundMemberDatatype.java

@@ -85,7 +85,6 @@ public CompoundMemberDatatype(String name, int offset, int dimensionality, int d
             case VLEN -> computeVariableLengthMessageDataSize(name);
             case ARRAY -> computeArrayMessageDataSize(name);
         };
-//        log.debug("CompoundMemberDatatype {}", this);
     }
 
     private short computeFixedMessageDataSize(String name) {

src/main/java/org/hdf5javalib/datatype/FloatingPointDatatype.java

@@ -335,23 +335,13 @@ public double toDoubleValue(byte[] rawBuffer) {
     public ByteOrder getByteOrder() {
         boolean bit0 = classBitField.get(0);
         boolean bit6 = classBitField.get(6);
-        if (!bit6 && !bit0) return ByteOrder.LITTLE_ENDIAN;
-        if (!bit6 && bit0) return ByteOrder.BIG_ENDIAN;
-        if (bit6 && !bit0) throw new IllegalArgumentException("Reserved byte order");
-        if (bit6 && bit0) throw new UnsupportedOperationException("VAX-endian not supported");
-        return ByteOrder.LITTLE_ENDIAN; // Default, should never reach here
-    }
 
-    private int getSignLocation() {
-        int signLoc = 0;
-        for (int i = 8; i <= 15; i++) {
-            if (classBitField.get(i)) {
-                signLoc |= (1 << (i - 8));
-            }
+        if (bit6) {
+            throw bit0 ? new UnsupportedOperationException("VAX-endian not supported")
+                    : new IllegalArgumentException("Reserved byte order");
         }
-        return signLoc;
+        return bit0 ? ByteOrder.BIG_ENDIAN : ByteOrder.LITTLE_ENDIAN;
     }
-
     /**
      * Returns a string representation of this FloatingPointDatatype.
      *

src/main/java/org/hdf5javalib/package-info.java

@@ -6,14 +6,6 @@
  * <p>This package enables Java developers to access and manipulate HDF5 data without requiring external native libraries,
  * making it suitable for scientific computing, data analysis, and applications dealing with large hierarchical datasets.</p>
  *
- * <p>Key features include:
- * <ul>
- *   <li>Reading of root-group datasets with robust datatype support.</li>
- *   <li>No external dependencies beyond Java 17 or higher.</li>
- *   <li>Maven integration for easy inclusion in projects.</li>
- * </ul>
- * </p>
- *
  * <p>For detailed usage examples and reading capabilities, refer to the project documentation.</p>
  *
  * @since 0.1.3