Skip to content

Commit e141812

Browse files
committed
Fix sandbox CI bootstrap and e2e lint
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
1 parent 62ad14a commit e141812

2 files changed

Lines changed: 6 additions & 11 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ jobs:
7575
run: |
7676
kubectl apply -f "https://github.com/kubernetes-sigs/agent-sandbox/releases/download/${AGENT_SANDBOX_VERSION}/manifest.yaml"
7777
kubectl wait --for=condition=Established crd/sandboxes.agents.x-k8s.io --timeout=90s
78-
kubectl rollout status statefulset/agent-sandbox-controller -n agent-sandbox-system --timeout=120s
78+
kubectl rollout status deployment/agent-sandbox-controller -n agent-sandbox-system --timeout=120s
7979
kubectl wait --for=condition=Ready pod -l app=agent-sandbox-controller -n agent-sandbox-system --timeout=120s
8080
8181
- name: Install Kagent
@@ -126,15 +126,15 @@ jobs:
126126
run: |
127127
# Upgrade helm to use namespace-scoped RBAC
128128
make helm-install-provider
129-
129+
130130
# Wait for controller to be ready after upgrade
131131
kubectl rollout status deployment/kagent-controller -n kagent --timeout=90s
132-
132+
133133
# Setup environment variables (reusing logic from previous step)
134134
HOST_IP=$(docker network inspect kind -f '{{range .IPAM.Config}}{{if .Gateway}}{{.Gateway}}{{"\n"}}{{end}}{{end}}' | grep -E '^[0-9]+\.' | head -1)
135135
export KAGENT_LOCAL_HOST=$HOST_IP
136136
export KAGENT_URL="http://$(kubectl get svc -n kagent kagent-controller -o jsonpath='{.status.loadBalancer.ingress[0].ip}'):8083"
137-
137+
138138
# Run critical tests with namespace-scoped RBAC to verify the controller didn't lose needed permissions
139139
cd go
140140
go test -v github.com/kagent-dev/kagent/go/core/test/e2e -run '^TestE2EInvokeInlineAgent$|^TestE2EInvokeDeclarativeAgentWithMcpServerTool$' -failfast
@@ -146,8 +146,8 @@ jobs:
146146
kubectl describe pods -n kagent
147147
echo "::error::Kubectl get pods -n agent-sandbox-system"
148148
kubectl get pods -n agent-sandbox-system -o wide || true
149-
echo "::error::Kubectl logs -n agent-sandbox-system statefulset/agent-sandbox-controller"
150-
kubectl logs -n agent-sandbox-system statefulset/agent-sandbox-controller || true
149+
echo "::error::Kubectl logs -n agent-sandbox-system deployment/agent-sandbox-controller"
150+
kubectl logs -n agent-sandbox-system deployment/agent-sandbox-controller || true
151151
echo "::error::Kubectl get events -n kagent"
152152
kubectl get events -n kagent
153153
echo "::error::Kubectl get agents -n kagent"

go/core/test/e2e/invoke_api_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,6 @@ func setupAgent(t *testing.T, cli client.Client, modelConfigName string, tools [
152152
return setupAgentWithOptions(t, cli, modelConfigName, tools, AgentOptions{})
153153
}
154154

155-
// setupSandboxAgent creates and returns a sandbox agent resource, then waits for it to be ready.
156-
func setupSandboxAgent(t *testing.T, cli client.Client, modelConfigName string, tools []*v1alpha2.Tool) *v1alpha2.SandboxAgent {
157-
return setupSandboxAgentWithOptions(t, cli, modelConfigName, tools, AgentOptions{})
158-
}
159-
160155
// AgentOptions provides optional configuration for agent setup
161156
type AgentOptions struct {
162157
Name string

0 commit comments

Comments
 (0)