Simplify with MatrixOfConstraints (#35)

* Simplify with MatrixOfConstraints

* Fix format

* Use MOI master

* Drop Julia v1.10

* Remove MathOptInterface installation from CI

Removed the installation step for the MathOptInterface package from the CI workflow.

* Apply suggestion from @blegat

* Update README to remove development version warning

Removed warning about needing the development version of MathOptInterface.

Author: blegat

.github/workflows/ci.yml

@@ -19,7 +19,7 @@ jobs:
           - version: '1'
             os: ubuntu-latest
             arch: x64
-          - version: '1.6'
+          - version: '1.10'
             os: ubuntu-latest
             arch: x64
           - version: '1'

Project.toml

@@ -3,13 +3,15 @@ uuid = "2f4eb8e6-3e35-4ae4-8c7a-f3d7d9bf20ed"
 version = "0.1.0"
 
 [deps]
+FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 
 [compat]
-MathOptInterface = "1"
-julia = "1.6"
+FillArrays = "1.15.0"
+MathOptInterface = "1.49"
+julia = "1.10"
 
 [extras]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

src/MatrixOptInterface.jl

@@ -6,6 +6,7 @@
 module MatrixOptInterface
 
 using LinearAlgebra, SparseArrays
+import FillArrays
 using MathOptInterface
 const MOI = MathOptInterface
 const MOIU = MathOptInterface.Utilities
@@ -67,6 +68,6 @@ end
 include("sparse_matrix.jl")
 include("conic_form.jl")
 include("matrix_input.jl")
-include("change_form.jl")
+#include("change_form.jl")
 
 end

src/change_form.jl

@@ -15,21 +15,6 @@ function change_form(::Type{LPForm{T,AT,VT}}, lp::LPForm) where {T,AT,VT}
     )
 end
 
-function change_form(
-    ::Type{LPForm{T,AT,VT}},
-    lp::LPStandardForm{T},
-) where {T,AT,VT}
-    return LPForm{T,AT,VT}(
-        lp.sense,
-        lp.c,
-        lp.A,
-        lp.b,
-        lp.b,
-        fill(zero(T), length(lp.c)),
-        fill(typemax(T), length(lp.c)),
-    )
-end
-
 function change_form(
     ::Type{LPForm{T,AT,VT}},
     lp::LPGeometricForm{T},
@@ -125,31 +110,6 @@ function change_form(
     return change_form(LPGeometricForm{T,AT,VT}, temp_lp)
 end
 
-function change_form(
-    ::Type{LPStandardForm{T,AT,VT}},
-    lp::LPStandardForm,
-) where {T,AT,VT}
-    return LPStandardForm(lp.sense, lp.c, lp.A, lp.b)
-end
-
-function change_form(
-    ::Type{LPStandardForm{T,AT,VT}},
-    lp::LPGeometricForm{T},
-) where {T,AT,VT}
-    new_A = hcat(lp.A, -lp.A, AT(I, length(lp.b), length(lp.b)))
-    new_c = vcat(lp.c, -lp.c, fill(0.0, length(lp.b)))
-    return LPStandardForm{T,AT,VT}(lp.sense, new_c, new_A, copy(lp.b))
-end
-
-function change_form(
-    ::Type{LPStandardForm{T,AT,VT}},
-    lp::F,
-) where {T,AT,VT,F<:AbstractLPForm{T}}
-    temp_lp = change_form(LPForm{T,AT,VT}, lp)
-    new_lp = change_form(LPGeometricForm{T,AT,VT}, temp_lp)
-    return change_form(LPStandardForm{T,AT,VT}, new_lp)
-end
-
 function change_form(
     ::Type{LPSolverForm{T,AT,VT}},
     lp::LPSolverForm,