format and int generic for x86 (#13)

* format and int generic for x86

* replace implementation with dimension

Author: matbesancon

Project.toml

@@ -20,4 +20,4 @@ SCS = "c946c3f1-0d1f-5ce8-9dea-7daa1f7e2d13"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Test","SCS","ProxSDP","COSMO"]
+test = ["Test", "SCS", "ProxSDP", "COSMO"]

src/MatrixOptInterface.jl

@@ -19,7 +19,7 @@ _sense(::Type{<:MOI.Interval}) = INTERVAL
 _no_upper(bound) = bound != typemax(bound)
 _no_lower(bound) = bound != typemin(bound)
 
-function _bound_sense(lb::T, ub::T) where T
+function _bound_sense(lb::T, ub::T) where {T}
     if _no_upper(ub)
         if _no_lower(lb)
             if lb == ub
@@ -38,6 +38,7 @@ function _bound_sense(lb::T, ub::T) where T
         end
     end
 end
+
 function _bound_set(lb::T, ub::T) where T
     if _no_upper(ub)
         if _no_lower(lb)

src/conic_form.jl

@@ -26,14 +26,14 @@ _set_type(::MOI.ConstraintIndex{F,S}) where {F,S} = S
 cons_offset(conic::MOI.Zeros) = conic.dimension
 cons_offset(conic::MOI.Nonnegatives) = conic.dimension
 cons_offset(conic::MOI.SecondOrderCone) = conic.dimension
-cons_offset(conic::MOI.PositiveSemidefiniteConeTriangle) = Int64((conic.side_dimension*(conic.side_dimension+1))/2)
+cons_offset(conic::MOI.PositiveSemidefiniteConeTriangle) = MOI.dimension(conic)
 
 function get_conic_form(::Type{T}, model::M, con_idx) where {T, M <: MOI.AbstractOptimizer}
     # extract cones
     cones = _set_type.(con_idx)
     cones = unique(cones)
 
-    conic = ConicForm{T, SparseMatrixCSRtoCSC{Int64}, Array{T, 1}}(Tuple(cones))
+    conic = ConicForm{T, SparseMatrixCSRtoCSC{Int}, Array{T, 1}}(Tuple(cones))
 
     idxmap = MOI.copy_to(conic, model)
 

src/matrix_input.jl

@@ -3,6 +3,7 @@ abstract type AbstractLPForm{T} <: MOI.ModelLike end
 # FIXME Taken from Polyhedra.jl, we should maybe move this to MOIU
 structural_nonzero_indices(a::SparseArrays.SparseVector) = SparseArrays.nonzeroinds(a)
 structural_nonzero_indices(a::AbstractVector) = eachindex(a)
+
 function _dot_terms(a::AbstractVector{T}) where T
     return MOI.ScalarAffineTerm{T}[
         MOI.ScalarAffineTerm{T}(a[i], MOI.VariableIndex(i))