Update

Author: odow

src/FileFormats/NL/read.jl

@@ -403,12 +403,7 @@ function _parse_header(io::IO, model::_CacheModel)
     # them
     _read_til_newline(io, model)
     # Line 10
-    # We don't support reading common subexpressions
-    for _ in 1:5
-        if _next(Int, io, model) > 0
-            error("Unable to parse NL file : we don't support common exprs")
-        end
-    end
+    # We support subexpressions, but we don't need to know the details yet.
     _read_til_newline(io, model)
     # ==========================================================================
     # Deal with the integrality of variables. This is quite complicated, so go

test/FileFormats/NL/test_read.jl

@@ -166,26 +166,6 @@ function test_parse_header_assertion_errors()
     return
 end
 
-function test_parse_header_common_expressions()
-    model = NL._CacheModel()
-    err = ErrorException(
-        "Unable to parse NL file : we don't support common exprs",
-    )
-    for header in [
-        "g3 1 1 0\n4 2 1 0 1 0\n2 1\n0 0\n4 0 0\n0 0 0 1\n0 0 0 2 0\n8 4\n0 0\n1 0 0 0 0\n",
-        "g3 1 1 0\n4 2 1 0 1 0\n2 1\n0 0\n4 0 0\n0 0 0 1\n0 0 0 2 0\n8 4\n0 0\n0 1 0 0 0\n",
-        "g3 1 1 0\n4 2 1 0 1 0\n2 1\n0 0\n4 0 0\n0 0 0 1\n0 0 0 2 0\n8 4\n0 0\n0 0 1 0 0\n",
-        "g3 1 1 0\n4 2 1 0 1 0\n2 1\n0 0\n4 0 0\n0 0 0 1\n0 0 0 2 0\n8 4\n0 0\n0 0 0 1 0\n",
-        "g3 1 1 0\n4 2 1 0 1 0\n2 1\n0 0\n4 0 0\n0 0 0 1\n0 0 0 2 0\n8 4\n0 0\n0 0 0 0 1\n",
-    ]
-        io = IOBuffer()
-        write(io, header)
-        seekstart(io)
-        @test_throws(err, NL._parse_header(io, model))
-    end
-    return
-end
-
 function test_parse_y_error()
     model = NL._CacheModel()
     NL._resize_variables(model, 4)