Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Commit 09bae15

Browse files
joachimdalenjoachimdalen
authored
Fix release ui crashing when using PullRequestStatus (#16)
1 parent 94f43af commit 09bae15

5 files changed

Lines changed: 93 additions & 24 deletions

File tree

‎.azext/changelog-cache.json‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
{
22
"issues": [
3+
{
4+
"id": 1343469705,
5+
"number": 15,
6+
"submitter": "teuciont",
7+
"title": "Azure classic release \"Pull Request Status\" task: Unable to set action to Update",
8+
"url": "https://github.com/joachimdalen/azdevops-pull-request-utils/issues/15"
9+
},
10+
{
11+
"id": 1341413671,
12+
"number": 13,
13+
"submitter": "knoxi",
14+
"title": "PullRequest Comment Task don't set proper status",
15+
"url": "https://github.com/joachimdalen/azdevops-pull-request-utils/issues/13"
16+
},
317
{
418
"id": 1231461604,
519
"number": 10,
@@ -16,6 +30,20 @@
1630
}
1731
],
1832
"pullRequests": [
33+
{
34+
"id": 1031714364,
35+
"number": 16,
36+
"submitter": "joachimdalen",
37+
"title": "Fix release ui crashing when using PullRequestStatus",
38+
"url": "https://github.com/joachimdalen/azdevops-pull-request-utils/pull/16"
39+
},
40+
{
41+
"id": 1029152486,
42+
"number": 14,
43+
"submitter": "joachimdalen",
44+
"title": "Deprecate system comment type",
45+
"url": "https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14"
46+
},
1947
{
2048
"id": 933969209,
2149
"number": 11,

‎.azext/changelog.json‎

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"changes": [
1010
{
1111
"type": "maint",
12-
"description": "Update dependencies"
12+
"description": "Update dependencies",
13+
"pullRequest": 14
1314
}
1415
]
1516
},
@@ -19,17 +20,31 @@
1920
"changes": [
2021
{
2122
"type": "maint",
22-
"description": "Update dependencies"
23+
"description": "Update dependencies",
24+
"pullRequest": 14
25+
},
26+
{
27+
"type": "fix",
28+
"description": "Deprecate the `type` option. System comments are causing issues and not really supported",
29+
"issue": 13,
30+
"pullRequest": 14
2331
}
2432
]
2533
},
2634
{
2735
"name": "PullRequestStatus",
28-
"version": "0.5.1",
36+
"version": "0.5.2",
2937
"changes": [
3038
{
3139
"type": "maint",
32-
"description": "Update dependencies"
40+
"description": "Update dependencies",
41+
"pullRequest": 14
42+
},
43+
{
44+
"type": "fix",
45+
"description": "Fix release ui crashing when setting the status to `Update`",
46+
"issue": 15,
47+
"pullRequest": 16
3348
}
3449
]
3550
},
@@ -39,7 +54,8 @@
3954
"changes": [
4055
{
4156
"type": "maint",
42-
"description": "Update dependencies"
57+
"description": "Update dependencies",
58+
"pullRequest": 14
4359
}
4460
]
4561
}

‎CHANGELOG.md‎

Lines changed: 41 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,43 @@
77
#### `PullRequestDescription@0.5.1`
88

99
- Update dependencies
10+
- Changed in [PR#14 - Deprecate system comment type](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14)
1011

1112
#### `PullRequestComments@0.4.1`
1213

1314
- Update dependencies
15+
- Changed in [PR#14 - Deprecate system comment type](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14)
1416

15-
#### `PullRequestStatus@0.5.1`
17+
#### `PullRequestStatus@0.5.2`
1618

1719
- Update dependencies
20+
- Changed in [PR#14 - Deprecate system comment type](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14)
1821

1922
#### `PullRequestTags@0.4.1`
2023

2124
- Update dependencies
25+
- Changed in [PR#14 - Deprecate system comment type](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14)
26+
27+
### 🐛 Fixes (2)
28+
29+
#### `PullRequestComments@0.4.1`
30+
31+
- Deprecate the `type` option. System comments are causing issues and not really supported
32+
- Reported in [GH#13 - PullRequest Comment Task don't set proper status](https://github.com/joachimdalen/azdevops-pull-request-utils/issues/13)
33+
- Fixed in [PR#14 - Deprecate system comment type](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/14)
34+
35+
#### `PullRequestStatus@0.5.2`
36+
37+
- Fix release ui crashing when setting the status to `Update`
38+
- Reported in [GH#15 - Azure classic release "Pull Request Status" task: Unable to set action to Update](https://github.com/joachimdalen/azdevops-pull-request-utils/issues/15)
39+
- Fixed in [PR#16 - Fix release ui crashing when using PullRequestStatus](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/16)
40+
41+
## 🌟 Contributors
42+
43+
Thank you to the following for contributing to the latest release
44+
45+
- [@teuciont](https://github.com/teuciont)
46+
- [@knoxi](https://github.com/knoxi)
2247

2348
---
2449

@@ -49,20 +74,20 @@ Thank you to the following for contributing to the latest release
4974

5075
## 1.1.0 (2022-03-25)
5176

52-
### 🚀 Features (1)
77+
### 🐛 Fixes (1)
5378

5479
#### `PullRequestStatus@0.5.0`
5580

56-
- Added new argument `whenState` to control when a status update should be applied
57-
- Suggested in [GH#7 - Update PullRequestStatus only if the status is fulfilled](https://github.com/joachimdalen/azdevops-pull-request-utils/issues/7)
58-
- Added in [PR#8 - Add option to conditionally update status](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/8)
81+
- Fixed an issue where action `Delete` did not load the correct status
82+
- Fixed in [PR#8 - Add option to conditionally update status](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/8)
5983

60-
### 🐛 Fixes (1)
84+
### 🚀 Features (1)
6185

6286
#### `PullRequestStatus@0.5.0`
6387

64-
- Fixed an issue where action `Delete` did not load the correct status
65-
- Fixed in [PR#8 - Add option to conditionally update status](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/8)
88+
- Added new argument `whenState` to control when a status update should be applied
89+
- Suggested in [GH#7 - Update PullRequestStatus only if the status is fulfilled](https://github.com/joachimdalen/azdevops-pull-request-utils/issues/7)
90+
- Added in [PR#8 - Add option to conditionally update status](https://github.com/joachimdalen/azdevops-pull-request-utils/pull/8)
6691

6792
## 🌟 Contributors
6893

@@ -307,6 +332,14 @@ Thank you to the following for contributing to the latest release
307332

308333
## 0.4.2 (2021-01-27)
309334

335+
### 🐛 Fixes (2)
336+
337+
#### `PullRequestComments@0.2.0`
338+
339+
- Fixed `skipIfCommentExists` not working properly. It was dumb previously and only checked the content of the comment. It is now updated to add a hidden identifier to the comment to properly identify if it exists. If you use multiple tasks, ensure `commentId` is set as a unique value for each task.
340+
341+
- Fixed some configuration options not showing in the editor
342+
310343
### 🚀 Features (3)
311344

312345
#### `PullRequestDescription@0.1.1`
@@ -319,14 +352,6 @@ Thank you to the following for contributing to the latest release
319352

320353
- Added option `action`, you can now create or update comments.
321354

322-
### 🐛 Fixes (2)
323-
324-
#### `PullRequestComments@0.2.0`
325-
326-
- Fixed `skipIfCommentExists` not working properly. It was dumb previously and only checked the content of the comment. It is now updated to add a hidden identifier to the comment to properly identify if it exists. If you use multiple tasks, ensure `commentId` is set as a unique value for each task.
327-
328-
- Fixed some configuration options not showing in the editor
329-
330355
---
331356

332357
## 0.2.2 (2021-01-11)

‎tasks/pull-request-comments/task.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
},
8383
{
8484
"name": "type",
85-
"label": "Comment Type",
85+
"label": "Comment Type (Deprecated)",
8686
"type": "pickList",
8787
"helpMarkDown": "The type of comment. `Text` represents a regular user comment while `System` indicates a system message",
8888
"defaultValue": "Text",

‎tasks/pull-request-status/task.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"version": {
1212
"Major": 0,
1313
"Minor": 5,
14-
"Patch": 1
14+
"Patch": 2
1515
},
1616
"instanceNameFormat": "$(Action)",
1717
"inputs": [
@@ -89,7 +89,7 @@
8989
},
9090
"visibleRule": "action = Update",
9191
"properties": {
92-
"MultiSelect": "True"
92+
"MultiSelectFlatList": "True"
9393
}
9494
}
9595
],

0 commit comments

Comments
 (0)