Main panel scrolling broken when running lazygit under tmux with 0.62.x versions

[scodougy]

Describe the bug

selecting a file to view diffs, the main pane (0) shows the text, but it is no longer scrollable when running under tmux.

running lazygit 0.62.x versions in a raw gnome terminal works fine, but running in a tmux session no longer works. It worked fine in 0.61.x

To Reproduce

launch tmux session
go to git controlled dir
run lazygit
select file to show diffs
no mouse scrolling text (it scrolls the wrong pane)
unable to select the text/diff view (panel 0) with mouse
selecting panel 0 by pressing entering 0 highlights that panel, but scroll wheel still scrolls previous panel

probably related:
unable to use mouse to select items in the repo selector window (ctrl-R)

Expected behavior

scrolling of text
selecting text panel 0 with mouse
ability to select repos with mouse

Version info:

0.62.1
0.62.2

Terminal info:

tmux within gnome terminal on mint/cinnamon and also lmde

[rasadov]

Hey @jesseduffield ,

I ran into this issue while using tmux and managed to consistently reproduce the freeze. I have some free time, so I'd love to dig into the codebase and see if I can put together a clean fix for it.

Since I read through the updated contribution guidelines, I just wanted to check first if you'd be open to a PR for this before I dive in?

[scodougy]

@rasadov

Hey @jesseduffield ,

I ran into this issue while using tmux and managed to consistently reproduce the freeze. I have some free time, so I'd love to dig into the codebase and see if I can put together a clean fix for it.

I'm not sure you're seeing the same bug as me. I am not seeing any 'freeze' per. se. - my .62x app generally works fine. It's just the mouse scroll wheel doesn't scroll the main pane (panel 0) and there is no way to select the panel to even do keyboard navigation/scrolling.

[rasadov]

@rasadov

Hey @jesseduffield ,
I ran into this issue while using tmux and managed to consistently reproduce the freeze. I have some free time, so I'd love to dig into the codebase and see if I can put together a clean fix for it.

I'm not sure you're seeing the same bug as me. I am not seeing any 'freeze' per. se. - my .62x app generally works fine. It's just the mouse scroll wheel doesn't scroll the main pane (panel 0) and there is no way to select the panel to even do keyboard navigation/scrolling.

Ah got it, thanks for the clarification! On my end, rapid scrolling actually locks up the UI until I hit Esc. I might be seeing a different bug then.

[stefanhaller]

@scodougy I am not a tmux user and I'm very unfamiliar with it. I just installed it, ran it with no arguments and no config file, and then started lazygit (current master version) inside it, and I don't see a problem: two-finger scrolling on my trackpad scrolls the pane under the mouse. Works fine for the main view. My tmux version is 3.6b.

I wonder if this could be some weird interaction between the terminal and tmux? I'm using ghostty, maybe you want to try if this works better?

@rasadov Thanks, but this project no longer accepts PRs. Help is still very much appreciated, so if you can investigate a bug and find its root cause, this would be great. Just no PRs.

[scodougy]

@stefanhaller Thanks for responding. I don't have ghostty. It's not in the official apt repo and my simple attempts to manually install it have failed. I'm running Mint 21.3 on one machine (tmux 3.2a) and LMDE 6 on another (tmux 3.3a) and both fail the same way. The default TERM is screen-256color, but I tried xterm-256color and it acts the same. gnome-terminal is most ubiquitous and readily available and it would seem a presumed target for the project to support. I'm not a a go developer (long time c/c++ dev) and I've been unable to get the needed dev environment up to build lazygit myself. If there's anything I can do, e.g. run an instrumented version to collect logs etc, I'd be willing to do that.

[stefanhaller]

@scodougy I tried it in a Ubuntu VM too now, using gnome-terminal 3.52.0 and tmux 3.7. Works fine for me, I'm honestly not sure what to do with this issue.

[scodougy]

@stefanhaller So I guessed that if no-one else is seeing it, it must be something in my tmux.conf, which has lots of customizations.
I found this one:
set -g mouse on
which seems to be the culprit. my notes say I did that to improve text selection via mouse, but research says it can cause tmux to consume all mouse events and not necessarily pass them all to the child apps. With that removed, 0.62.2 works as expected (quick testing at least).

Not sure if this is something you want to look into on your side. I'm not sure exactly how removing that config changes my tmux usability yet, but I obviously did it for a reason (probably 5+ years ago), and lazygit worked fine with it before the .62x series. My little research says it could be a bug in recent versions of tcell. It may be possible you could resolve this with different tcell settings, or manually telling the terminal you want mouse events via ANSI escape codes (e.g. SGR mouse mode).

For now I'm back on the latest version of lazygit, yay! I really appreciate the tool, as it allows me to shell-out of vim into a good git tui tool and stay in the terminal instead of moving to a gui tool. That's especially important for me because much of the work I do is via an ssh terminal, so sub-launching a gui tool is mostly off the table for those sessions.

Let me know if there's anything more I can do if you want help pursuing this further. At minimum it may be worthwhile adding a warning in the release notes. Cheers.

[scodougy]

@stefanhaller I see now removing that mouse config line on my Cinnamon/Mint 21.3 system solves the problem, but not on my LMDE 6 system. WTF? TODO more testing. I have a bunch of VMs built up with all kinds of other systems that I haven't used in a while, I'll work on getting them going and see if I can find more info. Grrr.