Tweak CI settings for asan to see what sticks

Author: jepler

.github/workflows/ports_unix.yml

@@ -274,11 +274,11 @@ jobs:
     - name: Run main test suite
       run: source tools/ci.sh && ci_unix_sanitize_address_run_tests
     - name: Test merging .mpy files
-      run: source tools/ci.sh && ci_unix_coverage_run_mpy_merge_tests
+      run: source tools/ci.sh && ci_unix_sanitize_address_run_mpy_merge_tests
     - name: Build native mpy modules
       run: source tools/ci.sh && ci_native_mpy_modules_build
     - name: Test importing .mpy generated by mpy_ld.py
-      run: source tools/ci.sh && ci_unix_coverage_run_native_mpy_tests
+      run: source tools/ci.sh && ci_unix_sanitize_address_run_native_mpy_tests
     - name: Print failures
       if: failure()
       run: tests/run-tests.py --print-failures

tools/ci.sh

@@ -514,14 +514,16 @@ CI_UNIX_OPTS_QEMU_RISCV64=(
 
 CI_UNIX_OPTS_SANITIZE_ADDRESS=(
     VARIANT=coverage
-    CFLAGS_EXTRA="-fsanitize=address"
+    CFLAGS_EXTRA="-DMICROPY_ASAN -fsanitize=address -g"
     LDFLAGS_EXTRA="-fsanitize=address"
+    STRIP=:
 )
 
 CI_UNIX_OPTS_SANITIZE_UNDEFINED=(
     VARIANT=coverage
-    CFLAGS_EXTRA="-fsanitize=undefined -fno-sanitize=nonnull-attribute"
-    LDFLAGS_EXTRA="-fsanitize=undefined -fno-sanitize=nonnull-attribute"
+    CFLAGS_EXTRA="-fsanitize=undefined -fno-sanitize=nonnull-attribute -g"
+    LDFLAGS_EXTRA="--fsanitize=undefined -fno-sanitize=nonnull-attribute"
+    STRIP=:
 )
 
 function ci_unix_build_helper {
@@ -773,12 +775,20 @@ function ci_unix_sanitize_address_build {
 }
 
 function ci_unix_sanitize_address_run_tests {
-    # Detect_stack_use_after_return causes failures because
-    # micropython's assumptions about stack usage are not met.
+    # The address sanitizer's "detect_stack_use_after_return" mode causes
+    # failures because micropython's assumptions about stack usage are not met.
     # The specific reasons why are not known.
     ASAN_OPTIONS=detect_stack_use_after_return=0 ci_unix_run_tests_full_helper coverage "${CI_UNIX_OPTS_SANITIZE_ADDRESS[@]}"
 }
 
+function ci_unix_sanitize_address_run_mpy_merge_tests {
+    ASAN_OPTIONS=detect_stack_use_after_return=0 ci_unix_coverage_run_mpy_merge_tests
+}
+
+function ci_unix_sanitize_address_run_native_mpy_tests {
+    ASAN_OPTIONS=detect_stack_use_after_return=0 ci_unix_coverage_run_mpy_native_mpy_tests
+}
+
 function ci_unix_macos_build {
     make ${MAKEOPTS} -C mpy-cross
     make ${MAKEOPTS} -C ports/unix submodules