diff --git a/src/MiniCron.Tests/MiniCronTests.EventInvocationOutsideLock.cs b/src/MiniCron.Tests/MiniCronTests.EventInvocationOutsideLock.cs index c398b68..6086fa1 100644 --- a/src/MiniCron.Tests/MiniCronTests.EventInvocationOutsideLock.cs +++ b/src/MiniCron.Tests/MiniCronTests.EventInvocationOutsideLock.cs @@ -13,7 +13,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads( { var registry = new JobRegistry(); var eventHandlerStarted = new TaskCompletionSource(); - var eventHandlerCanComplete = new TaskCompletionSource(); + using var eventHandlerCanComplete = new ManualResetEventSlim(false); var getJobsCompleted = new TaskCompletionSource(); // Subscribe to JobAdded with a long-running handler @@ -22,7 +22,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads( eventHandlerStarted.SetResult(true); // Simulate a slow event handler (e.g., logging to database) // Block synchronously until signaled - eventHandlerCanComplete.Task.GetAwaiter().GetResult(); + eventHandlerCanComplete.Wait(); }; // Schedule a job (which will trigger JobAdded event) @@ -47,7 +47,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads( await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask); // Now allow event handler to complete - eventHandlerCanComplete.SetResult(true); + eventHandlerCanComplete.Set(); await scheduleTask; } @@ -61,14 +61,14 @@ public async Task JobRegistry_JobRemoved_InvokedOutsideLock_AllowsConcurrentRead var jobId = registry.ScheduleJob("* * * * *", () => { }); var eventHandlerStarted = new TaskCompletionSource(); - var eventHandlerCanComplete = new TaskCompletionSource(); + using var eventHandlerCanComplete = new ManualResetEventSlim(false); var getJobsCompleted = new TaskCompletionSource(); // Subscribe to JobRemoved with a long-running handler registry.JobRemoved += (_, _) => { eventHandlerStarted.SetResult(true); - eventHandlerCanComplete.Task.GetAwaiter().GetResult(); + eventHandlerCanComplete.Wait(); }; // Remove the job (which will trigger JobRemoved event) @@ -92,7 +92,7 @@ public async Task JobRegistry_JobRemoved_InvokedOutsideLock_AllowsConcurrentRead await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask); // Allow event handler to complete - eventHandlerCanComplete.SetResult(true); + eventHandlerCanComplete.Set(); await removeTask; } @@ -106,14 +106,14 @@ public async Task JobRegistry_JobUpdated_InvokedOutsideLock_AllowsConcurrentRead var jobId = registry.ScheduleJob("* * * * *", () => { }); var eventHandlerStarted = new TaskCompletionSource(); - var eventHandlerCanComplete = new TaskCompletionSource(); + using var eventHandlerCanComplete = new ManualResetEventSlim(false); var getJobsCompleted = new TaskCompletionSource(); // Subscribe to JobUpdated with a long-running handler registry.JobUpdated += (_, _) => { eventHandlerStarted.SetResult(true); - eventHandlerCanComplete.Task.GetAwaiter().GetResult(); + eventHandlerCanComplete.Wait(); }; // Update the job schedule (which will trigger JobUpdated event) @@ -138,7 +138,7 @@ public async Task JobRegistry_JobUpdated_InvokedOutsideLock_AllowsConcurrentRead await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask); // Allow event handler to complete - eventHandlerCanComplete.SetResult(true); + eventHandlerCanComplete.Set(); await updateTask; }