Skip to content

Commit 58fc0cd

Browse files
committed
Fixed incorrect naming
1 parent 16bb44e commit 58fc0cd

5 files changed

Lines changed: 15 additions & 15 deletions

File tree

src/main/java/Application.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//usr/bin/env java --enable-preview --class-path ${APP_DIR:-.}/lib/'*' "$0" "$@"; exit $?
22

3-
import language.api.Greeting;
4-
import language.api.Greeting.Language;
3+
import language.api.Greeter;
4+
import language.api.Greeter.Language;
55

66
import picocli.CommandLine;
77
import picocli.CommandLine.Command;
@@ -19,6 +19,6 @@ private int polyglotHello(
1919
@Option(names = {"-l", "--language"}, required = true, description = "Valid values are: ${COMPLETION-CANDIDATES}")
2020
Language language
2121
) {
22-
println(Greeting.byLanguage(language).getGreeting());
22+
println(Greeter.byLanguage(language).greet());
2323
return CommandLine.ExitCode.OK;
2424
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
import language.en.Hello;
44
import language.fr.Bonjour;
55

6-
public interface Greeting {
6+
public interface Greeter {
77

88
enum Language {
99
French, English
1010
}
1111

12-
String getGreeting();
12+
String greet();
1313

14-
static Greeting byLanguage(Language language) {
14+
static Greeter byLanguage(Language language) {
1515
return switch (language) {
1616
case French -> new Bonjour();
1717
case English -> new Hello();
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package language.en;
22

3-
import language.api.Greeting;
3+
import language.api.Greeter;
44

5-
public class Hello implements Greeting {
5+
public class Hello implements Greeter {
66

77
@Override
8-
public String getGreeting() {
8+
public String greet() {
99
return "Hello " + Character.toString(0x1F1EC) + Character.toString(0x1F1E7);
1010
}
1111
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package language.fr;
22

3-
import language.api.Greeting;
3+
import language.api.Greeter;
44

5-
public class Bonjour implements Greeting {
5+
public class Bonjour implements Greeter {
66

77
@Override
8-
public String getGreeting() {
8+
public String greet() {
99
return "Bonjour " + Character.toString(0x1F1EB) + Character.toString(0x1F1F7);
1010
}
1111
}

src/test/java/language/api/GreetingTest.java renamed to src/test/java/language/api/GreeterTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@
66

77
import static org.junit.jupiter.api.Assertions.assertTrue;
88

9-
class GreetingTest {
9+
class GreeterTest {
1010

1111
@Test
1212
void bonjourShouldSayBonjour() {
1313
Bonjour bonjour = new Bonjour();
14-
assertTrue(bonjour.getGreeting().startsWith("Bonjour"));
14+
assertTrue(bonjour.greet().startsWith("Bonjour"));
1515
}
1616

1717
@Test
1818
void helloShouldSayHello() {
1919
Hello hello = new Hello();
20-
assertTrue(hello.getGreeting().startsWith("Hello"));
20+
assertTrue(hello.greet().startsWith("Hello"));
2121
}
2222
}

0 commit comments

Comments
 (0)