Skip to content

Commit a4f866c

Browse files
aniketkatkar97Jatin Masaram
authored andcommitted
Chore(UI): Refactor all custom property tests (open-metadata#27206)
* Refactor all custom property tests to bring under 1 serial describe block to avoid flakiness * Merged 3 parts to 1 * Fix checkstyle * Fix checkstyle * Worked on comments * Fix playwright checkstyle * Fix failing tests * Fix playwright checkstyle * Fix ExploreRightPanel failing tests and remove cp creation/deletion references from the remaining tests * Remove remaining references of custom properties from other specs * Fix playwright checkstyle * Fix failing tests * Worked on comments * Fix playwright checkstyle * Remove the error thrown while deletion failed since the we use these in cleanups and throwing error gives failure status even after tests are passed * Fix flakiness in CustomProperties spec * update playwright config for testing * Fix table data card selection logic to fix flakiness * add missing await * click on card by fqn when it is present * Fix the flakiness in custom property spec * Fix flakiness * update playwright config * Fix test flakiness * update playwright config * check * fix * Fix checkstyle * Fix the failing tests * Fix ui-checkstyle * Fix checkstyle * Revert special characters from name
1 parent 4533257 commit a4f866c

28 files changed

Lines changed: 3949 additions & 4434 deletions

openmetadata-ui/src/main/resources/ui/playwright/constant/customProperty.ts

Lines changed: 61 additions & 283 deletions
Large diffs are not rendered by default.

openmetadata-ui/src/main/resources/ui/playwright/constant/explore.ts

Lines changed: 37 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
* See the License for the specific language governing permissions and
1111
* limitations under the License.
1212
*/
13+
import { EntityTypeEndpoint } from '../support/entity/Entity.interface';
14+
1315
export const EXPECTED_BUCKETS = [
1416
'table',
1517
'tableColumn',
@@ -153,15 +155,39 @@ export const DATA_ASSETS_SORT = [
153155
{ name: 'Metrics', filter: 'metric' },
154156
];
155157
export const ENDPOINT_TO_FILTER_MAP: Record<string, string> = {
156-
tables: 'Table',
157-
databases: 'Database',
158-
topics: 'Topic',
159-
dashboards: 'Dashboard',
160-
pipelines: 'Pipeline',
161-
searchIndexes: 'Search Index',
162-
mlmodels: 'ML Model',
163-
containers: 'Container',
164-
glossaryTerms: 'Glossary Term',
165-
tags: 'Tag',
166-
dataProducts: 'Data Product',
158+
[EntityTypeEndpoint.Table]: 'Table',
159+
[EntityTypeEndpoint.Database]: 'Database',
160+
[EntityTypeEndpoint.Topic]: 'Topic',
161+
[EntityTypeEndpoint.Dashboard]: 'Dashboard',
162+
[EntityTypeEndpoint.Pipeline]: 'Pipeline',
163+
[EntityTypeEndpoint.SearchIndex]: 'Search Index',
164+
[EntityTypeEndpoint.MlModel]: 'ML Model',
165+
[EntityTypeEndpoint.Container]: 'Container',
166+
[EntityTypeEndpoint.StoreProcedure]: 'Stored Procedure',
167+
[EntityTypeEndpoint.API_ENDPOINT]: 'API Endpoint',
168+
[EntityTypeEndpoint.API_COLLECTION]: 'API Collection',
169+
[EntityTypeEndpoint.DatabaseSchema]: 'Database Schema',
170+
[EntityTypeEndpoint.DataModel]: 'Data Model',
171+
[EntityTypeEndpoint.DATA_PRODUCT]: 'Data Product',
172+
[EntityTypeEndpoint.GlossaryTerm]: 'Glossary',
173+
[EntityTypeEndpoint.Tag]: 'Tag',
174+
};
175+
176+
export const ENDPOINT_TO_EXPLORE_TAB_MAP: Record<string, string> = {
177+
[EntityTypeEndpoint.Table]: 'Tables',
178+
[EntityTypeEndpoint.Database]: 'Databases',
179+
[EntityTypeEndpoint.Topic]: 'Topics',
180+
[EntityTypeEndpoint.Dashboard]: 'Dashboards',
181+
[EntityTypeEndpoint.Pipeline]: 'Pipelines',
182+
[EntityTypeEndpoint.SearchIndex]: 'Search Indexes',
183+
[EntityTypeEndpoint.MlModel]: 'ML Models',
184+
[EntityTypeEndpoint.Container]: 'Containers',
185+
[EntityTypeEndpoint.StoreProcedure]: 'Stored Procedures',
186+
[EntityTypeEndpoint.API_ENDPOINT]: 'API Endpoints',
187+
[EntityTypeEndpoint.API_COLLECTION]: 'API Collections',
188+
[EntityTypeEndpoint.DatabaseSchema]: 'Database Schemas',
189+
[EntityTypeEndpoint.DataModel]: 'Dashboard Data Models',
190+
[EntityTypeEndpoint.DATA_PRODUCT]: 'Data Products',
191+
[EntityTypeEndpoint.GlossaryTerm]: 'Glossary Terms',
192+
[EntityTypeEndpoint.Tag]: 'Tags',
167193
};

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvanceSearchCustomProperty.spec.ts

Lines changed: 0 additions & 166 deletions
This file was deleted.

0 commit comments

Comments
 (0)