DevtoolsClient allow constructor injection of WebSocketClient

Author: holgerk

src/ChromeDevtoolsProtocol/DevtoolsClient.php

@@ -34,12 +34,18 @@ class DevtoolsClient implements DevtoolsClientInterface, InternalClientInterface
 	/** @var object[][] */
 	private $eventBuffers = [];
 
-	public function __construct(string $wsUrl)
+	public function __construct(WebSocketClient $wsClient)
 	{
-		$this->wsClient = new WebSocketClient($wsUrl, "http://" . parse_url($wsUrl, PHP_URL_HOST));
-		if (!$this->wsClient->connect()) {
+		$this->wsClient = $wsClient;
+	}
+
+	public static function createFromDebuggerUrl(string $wsUrl)
+	{
+		$wsClient = new WebSocketClient($wsUrl, "http://" . parse_url($wsUrl, PHP_URL_HOST));
+		if (!$wsClient->connect()) {
 			throw new RuntimeException(sprintf("Could not connect to [%s].", $wsUrl));
 		}
+		return new self($wsClient);
 	}
 
 	public function __destruct()

src/ChromeDevtoolsProtocol/Instance/Instance.php

@@ -103,7 +103,7 @@ public function createSession(ContextInterface $ctx, string $url = "about:blank"
 			throw new RuntimeException("No browser debugger URL. Try upgrading to newer version of Chrome.");
 		}
 
-		$browser = new DevtoolsClient($version->webSocketDebuggerUrl);
+		$browser = DevtoolsClient::createFromDebuggerUrl($version->webSocketDebuggerUrl);
 		try {
 			$browserContextId = $browser->target()->createBrowserContext($ctx)->browserContextId;
 			try {

src/ChromeDevtoolsProtocol/Instance/Tab.php

@@ -60,7 +60,7 @@ public function __construct($data, InternalInstanceInterface $internalInstance)
 	 */
 	public function devtools(): DevtoolsClientInterface
 	{
-		return new DevtoolsClient($this->webSocketDebuggerUrl);
+		return DevtoolsClient::createFromDebuggerUrl($this->webSocketDebuggerUrl);
 	}
 
 	/**