Use forked version of Poison to use Decimal v3#53
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the project to version 1.3.5 and switches the Poison dependency to a forked git repository that supports Decimal v3, while cleaning up the explicit Decimal dependency and documenting the change in the changelog. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
mix.exsthepoisondependency options include a typo (banchinstead ofbranch), which will prevent Mix from resolving the dependency correctly. - Consider pinning the git
poisondependency to a specific tag or commit rather thanmasterto avoid unexpected changes from upstream affecting builds.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `mix.exs` the `poison` dependency options include a typo (`banch` instead of `branch`), which will prevent Mix from resolving the dependency correctly.
- Consider pinning the git `poison` dependency to a specific tag or commit rather than `master` to avoid unexpected changes from upstream affecting builds.
## Individual Comments
### Comment 1
<location path="mix.exs" line_range="52" />
<code_context>
{:excoveralls, "~> 0.18", only: [:dev, :test], runtime: false},
{:mix_audit, "~> 2.1", only: [:dev, :test], runtime: false},
- {:poison, "~> 4.0 or ~> 5.0 or ~> 6.0"},
+ {:poison, git: "https://github.com/jaeyson/poison.git", banch: "master"},
{:oapi_generator, "~> 0.4.0", only: :dev, runtime: false},
- {:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
</code_context>
<issue_to_address>
**issue (bug_risk):** The `banch` option appears to be a typo and will be ignored by Mix.
Mix only recognizes `branch:` for Git dependencies; with `banch:` the branch isn’t pinned and Mix will use the default branch (or fail, depending on repo config). Please change this to `branch: "master"` (or another specific ref) so the dependency is resolved deterministically.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Gates Passed
3 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Closes #52
Summary by Sourcery
Update dependencies to use a forked Poison compatible with Decimal v3 and bump project version.
Enhancements:
Build:
Documentation: